Opened 7 years ago

Closed 7 years ago

#6901 closed Bug (fixed)

Toolbar buttons are not changed for mixed content using shared spaces

Reported by: Sa'ar Zac Elias Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.3
Component: Core : BiDi Version: 3.4 Beta
Keywords: Cc:

Description

Using shared spaces sample, change the paragraph's direction. Note that the toolbar buttons are not changed accordingly (#6041).

Attachments (4)

6901.patch (1.0 KB) - added by Sa'ar Zac Elias 7 years ago.
6901.PNG (20.8 KB) - added by Sa'ar Zac Elias 7 years ago.
6901_2.patch (2.0 KB) - added by Sa'ar Zac Elias 7 years ago.
6901_3.patch (2.1 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Garry Yao

Status: newconfirmed
Version: 3.4 Beta

BIDI didn't take toolbar out into consideration.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6901.patch added

comment:2 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

comment:3 Changed 7 years ago by Wiktor Walc

Could you attach a screenshot of the described issue? I'm having troubles with reproducing it in trunk using FF 3.6.13.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6901.PNG added

comment:4 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.2

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

BID plugin should have no knowledge of shared space.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6901_2.patch added

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:7 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Why not providing an "editor#contentDirChanged" event that consumed by theme and could be used by other plugins later.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6901_3.patch added

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:9 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

Guard over "directionNode " is unnecessary?

editor.fire( 'contentDirChanged', directionNode.getComputedStyle( 'direction' ));

comment:10 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6429].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy