Opened 7 years ago

Closed 7 years ago

#6909 closed Bug (fixed)

GIF icons of external plugins are not diplayed in toolbar

Reported by: andraz Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Toolbar Version: 3.5
Keywords: IE Cc: loudelement

Description

Icons of external plugin buttons are not displayed in IE7/IE8 in WYSIWYG mode. If switched to "source" mode, icons are displayed but dimmed (which is normal). When you switch back to WYSIWYG mode, some icons may show but still, they are dimmed.

If you change icon format from GIF to PNG, everything works as expected.

Attachments (2)

6909.patch (922 bytes) - added by Garry Yao 7 years ago.
6909_2.patch (7.2 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Cc: loudelement added
Keywords: IE added
Status: newconfirmed

#6944 has been marked as dup.

Confirmed with windows 2003, according to Garry, it works fine in windows 7.

comment:2 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Milestone: CKEditor 3.5.1

#6964 has been marked as dup.

comment:3 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Component: GeneralUI : Toolbar

comment:4 Changed 7 years ago by Wiktor Walc

Confirmed on IE8, Windows 7 N 64bit. I have attached a sample plugin in #6964 for easier testing.

comment:5 Changed 7 years ago by Alfonso Martínez de Lizarrondo

As reported in #6944 it can be checked also with the available "Placeholder" plugin.

comment:6 Changed 7 years ago by Garry Yao

WFM on IE9,Win7, confirmed on IE8,XP, regression of [6421].

Changed 7 years ago by Garry Yao

Attachment: 6909.patch added

comment:7 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

The hack of AlphaImageLoader doesn't work for GIF transparency, now the best option for us is to advocate PNG for toolbar icons.

comment:8 Changed 7 years ago by Wiktor Walc

Status: reviewreview_failed

The suggested fix does not solve the problem that people will have or already have with their own plugins. The common way of upgrading is simply downloading the new software without reading the list of changes, which means that we're doing a little surprise for the users.

Gif icons were not distorted with IE and zoom != 100% at all in previous versions of CKEditor, so why they should suddenly disappear from the toolbar if they didn't do anything wrong?

Changed 7 years ago by Garry Yao

Attachment: 6909_2.patch added

comment:9 Changed 7 years ago by Garry Yao

Status: review_failedreview

Adding a patch reflecting Wiktor's idea - as the filter is required only for PNG, we could remove the alphaImageLoader filter from those icons that are apparently other format, like GIF in ticket tc.

comment:10 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Let's change the name to a clearer one, like "noalphapix".

comment:11 in reply to:  10 Changed 7 years ago by Sa'ar Zac Elias

Replying to Saare:

Let's change the name to a clearer one, like "noalphapix".

Typo, "noalphafix" that is.

comment:12 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6319].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy