Opened 13 years ago
Closed 13 years ago
#6909 closed Bug (fixed)
GIF icons of external plugins are not diplayed in toolbar
| Reported by: | andraz | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.1 |
| Component: | UI : Toolbar | Version: | 3.5 |
| Keywords: | IE | Cc: | loudelement |
Description
Icons of external plugin buttons are not displayed in IE7/IE8 in WYSIWYG mode. If switched to "source" mode, icons are displayed but dimmed (which is normal). When you switch back to WYSIWYG mode, some icons may show but still, they are dimmed.
If you change icon format from GIF to PNG, everything works as expected.
Attachments (2)
Change History (14)
comment:1 Changed 13 years ago by
| Cc: | loudelement added |
|---|---|
| Keywords: | IE added |
| Status: | new → confirmed |
comment:3 Changed 13 years ago by
| Component: | General → UI : Toolbar |
|---|
comment:4 Changed 13 years ago by
Confirmed on IE8, Windows 7 N 64bit. I have attached a sample plugin in #6964 for easier testing.
comment:5 Changed 13 years ago by
As reported in #6944 it can be checked also with the available "Placeholder" plugin.
Changed 13 years ago by
| Attachment: | 6909.patch added |
|---|
comment:7 Changed 13 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | confirmed → review |
The hack of AlphaImageLoader doesn't work for GIF transparency, now the best option for us is to advocate PNG for toolbar icons.
comment:8 Changed 13 years ago by
| Status: | review → review_failed |
|---|
The suggested fix does not solve the problem that people will have or already have with their own plugins. The common way of upgrading is simply downloading the new software without reading the list of changes, which means that we're doing a little surprise for the users.
Gif icons were not distorted with IE and zoom != 100% at all in previous versions of CKEditor, so why they should suddenly disappear from the toolbar if they didn't do anything wrong?
Changed 13 years ago by
| Attachment: | 6909_2.patch added |
|---|
comment:9 Changed 13 years ago by
| Status: | review_failed → review |
|---|
Adding a patch reflecting Wiktor's idea - as the filter is required only for PNG, we could remove the alphaImageLoader filter from those icons that are apparently other format, like GIF in ticket tc.
comment:10 follow-up: 11 Changed 13 years ago by
| Status: | review → review_passed |
|---|
Let's change the name to a clearer one, like "noalphapix".
comment:11 Changed 13 years ago by
Replying to Saare:
Let's change the name to a clearer one, like "noalphapix".
Typo, "noalphafix" that is.
comment:12 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6319].
#6944 has been marked as dup.
Confirmed with windows 2003, according to Garry, it works fine in windows 7.