Opened 7 years ago

Closed 7 years ago

#6970 closed Bug (fixed)

IE: Dialog borders broken in v2 and office2003 skins

Reported by: qssam Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.1
Component: UI : Dialogs Version: 3.4.3
Keywords: IE Cc:

Description

In IE, when using the v2 or office2003 skins, dialog boxes have a gap in their borders. For most dialog boxes this is a 1px gap near the bottom of the dialog, but for the image dialog it's larger.

This can be seen in the CKEditor Sample by just changing the skin to v2 or office2003 in the config and then opening a dialog box.

Have found this problem in IE6, IE7, IE8 and IE9 Beta 1. The only difference is that in IE6 the gap is near the top of the dialog instead of the bottom.

Attachments (4)

image_dialog.jpg (75.1 KB) - added by qssam 7 years ago.
Image dialog in IE8
templates_dialog.jpg (48.0 KB) - added by qssam 7 years ago.
Templates dialog in IE8
6970.patch (4.2 KB) - added by Sa'ar Zac Elias 7 years ago.
6970_2.patch (4.7 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by qssam

Attachment: image_dialog.jpg added

Image dialog in IE8

Changed 7 years ago by qssam

Attachment: templates_dialog.jpg added

Templates dialog in IE8

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.5.1
Status: newconfirmed
Version: 3.53.4.3

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6970.patch added

comment:2 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

The chunk of code removed in the kama skin is dead as these elements are hidden.

comment:3 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1

comment:4 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1

(regression)

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6970_2.patch added

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

R+ for the first patch, I don't see difference of applying those dialog size change.

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6345].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy