Opened 8 years ago

Closed 8 years ago

#7037 closed Bug (fixed)

Incorrect remove preformatted block

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: Core : Styles Version: 3.5.1
Keywords: Cc:

Description

  1. Load with the following content and selection:
    <p>
    	pargraph[ one</p>
    <p>
    	pargraph ]two</p>
    
    
  2. Open format combo and click on preformatted block;
  3. Click again to remove formatted block;
  • Actual Result: Two paragraphs merged into one.
  • Expected Result: The original content is reverted.

Attachments (2)

7037.patch (846 bytes) - added by Garry Yao 8 years ago.
7037_2.patch (3.1 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by Sa'ar Zac Elias

Status: newconfirmed

Starting [6344].

comment:2 Changed 8 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1

comment:3 Changed 8 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedassigned

Changed 8 years ago by Garry Yao

Attachment: 7037.patch added

comment:4 Changed 8 years ago by Garry Yao

Owner: changed from Sa'ar Zac Elias to Garry Yao
Status: assignedreview

comment:5 Changed 8 years ago by Wiktor Walc

Status: reviewreview_failed

In enter mode = BR a div element is left in the source, when preformatted element is removed (if it has no extra attributes it makes no sense to leave it there).

Changed 8 years ago by Garry Yao

Attachment: 7037_2.patch added

comment:6 Changed 8 years ago by Garry Yao

Status: review_failedreview

comment:7 Changed 8 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Use the following:

<p>
	Pa[ra 1</p>
<p>
	&nbsp;</p>
<p>
	Pa]ra 2</p>

Apply preformatted style and remove it.
Expected: Original content is reverted.
Actual:

<p>
	Para 1</p>
<p>
	Para 2</p>

comment:8 Changed 8 years ago by Garry Yao

Status: review_failedreview

comment:9 Changed 8 years ago by Garry Yao

@Saar, the cited case is not a regression and opens #7065.

comment:10 Changed 8 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

(For reference, the very same can be reproduced when applying "normal" instead of removing the preformatted style).

comment:11 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6370].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy