Opened 14 years ago
Closed 13 years ago
#7153 closed Bug (fixed)
Can't dynamically load ckeditor_source.js
Reported by: | Damian | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.2 |
Component: | General | Version: | 3.0 |
Keywords: | IBM | Cc: | Satya Minnekanti, James Cunningham, Teresa Monahan |
Description
ckeditor_source.js uses document.write() when loading, this causes clearing of window variables when called at the end of a document load.
Proposal is that ckeditor_source.js (and ckeditor_basic_source.js) does something like this instead:
var head = document.getElementsByTagNam('head')[0]; var script = document.createElement('script'); script.type = 'text/javascript'; script.src = CKEDITOR.getUrl('_source/core/loader.js'); head.appendChild(script);
Attachments (3)
Change History (16)
comment:1 Changed 14 years ago by
Keywords: | Haspatch? added |
---|
Changed 14 years ago by
Attachment: | 7153.patch added |
---|
comment:2 Changed 14 years ago by
Keywords: | Haspatch? removed |
---|---|
Owner: | set to Frederico Caldeira Knabben |
Status: | new → review |
Changed 14 years ago by
comment:3 Changed 14 years ago by
Cc: | satya,jamescun,tmonahan → satya, jamescun, tmonahan |
---|---|
Status: | review → review_failed |
comment:4 Changed 14 years ago by
Owner: | Frederico Caldeira Knabben deleted |
---|---|
Status: | review_failed → new |
@garry.yao, I have some doubts about the possibility of supporting your TC. I did some research and I didn't find a good solution that will fit all needs.
The patch makes it possible to load the editor *after* document load. This is a common use case as well.
@damo, you may tell us which kind of support we should have here. Maybe the patch already gives what you want. Let us know. Thanks.
comment:5 Changed 14 years ago by
Status: | new → pending |
---|
comment:6 Changed 13 years ago by
Thanks Fred... this patch has been verified on our end and looks good.
comment:7 Changed 13 years ago by
Owner: | set to Frederico Caldeira Knabben |
---|---|
Status: | pending → review |
comment:8 Changed 13 years ago by
Owner: | changed from Frederico Caldeira Knabben to Garry Yao |
---|
@garry.yao, I have some doubts about the possibility of supporting your TC. I did some research and I didn't find a good solution that will fit all needs.
Can you check if the new patch is enough for resolving this case?
Changed 13 years ago by
Attachment: | 7153_2.patch added |
---|
comment:9 Changed 13 years ago by
Original ticket test: http://ckeditor.t/tt/7153/1.html
The extended test: http://ckeditor.t/tt/7153/2.html
comment:10 Changed 13 years ago by
I would ask to please reconsider patch 1 as it has already been verified. Additionally, the provided tests are not working.
comment:12 Changed 13 years ago by
Milestone: | → CKEditor 3.6.2 |
---|---|
Status: | review → review_passed |
Version: | → 3.0 |
comment:13 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7228].
The patch doesn't work for "interactive" document state which is quite a common case when using "DOMContentReady" event or padding body script block illustrated with the sample file.