Opened 6 years ago

Last modified 11 minutes ago

#7154 review New Feature

Add support for a Display Text field to the Link dialog

Reported by: tmonahan Owned by: m.lewandowski
Priority: Normal Milestone: CKEditor 4.5.11
Component: UI : Dialogs Version:
Keywords: IBM Cc: damo, satya, jamescun

Description

The current link dialog does not allow users to specify display text for the URL they are inserting. We would like to request support for a Display Text field on the link dialog so that users have this option. This would be consistent with the 'Insert Hyperlink' options in desktop editing programs such as Word, Lotus Symphony etc and has been requested by a lot of users.

Attachments (1)

7154.patch (3.6 KB) - added by garry.yao 5 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 5 years ago by tmonahan

One further note for this requested feature is that the link dialog does not necessarily need to expose a display text field. It would be sufficient for us if an extension point was added to the existing dialog so that we can add a Display Text field ourselves.

For example, the data object in dialogs\link.js that is used to record entered values such as data.target and data.url, could also support data.text. The onOK function would need to be extended to consume this value so that the entered text value can be applied to the html for the link.

comment:2 Changed 5 years ago by wwalc

  • Status changed from new to confirmed

In Word when inserting a link there is a "Text to display" field available. If some text was initially selected, this field is filled automatically with selected text. If selected content is more complicated, "Text to display" is grayed out and <<Selection in Document>> is shown. When editing exisiting links it works in the same way.

I'd say that this is the way to go. Adding such a field will make the dialog more usable, so there is no need to keep it as a hidden feature.

comment:3 Changed 5 years ago by tmonahan

It's great that you can also see value in this feature. Do you know what milestone this will be targeted for? We would love to see it in the 3.6 release if possible.

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

  • Component changed from General to UI : Dialogs
  • Owner set to garry.yao
  • Status changed from confirmed to review

comment:5 Changed 5 years ago by fredck

#8374 is DUP.

comment:6 Changed 5 years ago by luisete.serrano

I have applied the patch to the latest version and when you insert the link does not correctly (insert the url in the text) but when you edit and modify it if it does well.

comment:7 Changed 5 years ago by j.swiderski

Take also this ticket #8715 into account when reviewing this feature.

Also long time ago some other feature was implemented #4612. I'm just leaving this as a note so that one could make sure that this new feature is not causing any conflicts with this old one.

comment:8 Changed 6 months ago by m.lewandowski

We can see if we can implement it sometime soon.

We should review if we can use code from Garry's patch or do we need to put new code.

In case of questions during my absence @j.swiderski may answer your questions, so feel free to reach out for him.

Last edited 6 months ago by m.lewandowski (previous) (diff)

comment:9 Changed 6 months ago by m.lewandowski

  • Milestone set to CKEditor 4.5.8

comment:10 Changed 5 months ago by m.lewandowski

There is a pull request sent that attempts to bring this feature.

comment:11 Changed 5 months ago by m.lewandowski

  • Status changed from review to assigned

comment:12 Changed 5 months ago by m.lewandowski

  • Owner garry.yao deleted
  • Status changed from assigned to confirmed

comment:13 Changed 5 months ago by m.lewandowski

  • Milestone changed from CKEditor 4.5.8 to CKEditor 4.5.9

comment:14 Changed 4 months ago by m.lewandowski

  • Milestone changed from CKEditor 4.5.9 to CKEditor 4.5.10

comment:15 Changed 3 months ago by Tade0

  • Owner set to Tade0
  • Status changed from confirmed to assigned

comment:16 Changed 3 months ago by Tade0

  • Status changed from assigned to review

Modified the link text feature by https://github.com/ryanguill so that it conforms to the requirements described in https://github.com/ckeditor/ckeditor-dev/pull/265.

At this point I don't see a case, where the link text field would be disabled, which for me counts as a red flag.

Changed pushed to branch:t/7154.

comment:17 Changed 6 weeks ago by m.lewandowski

  • Milestone changed from CKEditor 4.5.10 to CKEditor 4.5.11

Moving tickets to the next milestone.

comment:18 Changed 24 hours ago by m.lewandowski

  • Owner changed from Tade0 to m.lewandowski
  • Status changed from review to assigned

Taking over this issue.

comment:19 Changed 11 minutes ago by m.lewandowski

  • Status changed from assigned to review

Pushed for a review to branch:t/7154.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy