Can't dynamically load ckeditor_source.js

[Damian]

ckeditor_source.js uses document.write() when loading, this causes clearing of window variables when called at the end of a document load.

Proposal is that ckeditor_source.js (and ckeditor_basic_source.js) does something like this instead:

var head = document.getElementsByTagNam('head')[0];
var script = document.createElement('script');
script.type = 'text/javascript';
script.src = CKEDITOR.getUrl('_source/core/loader.js');
head.appendChild(script);

[Garry Yao]

The patch doesn't work for "interactive" document state which is quite a common case when using "DOMContentReady" event or padding body script block illustrated with the sample file.

7153.html is not working in at least FF4/IE8/IE9.

[Frederico Caldeira Knabben]

@garry.yao, I have some doubts about the possibility of supporting your TC. I did some research and I didn't find a good solution that will fit all needs.

The patch makes it possible to load the editor *after* document load. This is a common use case as well.

@damo, you may tell us which kind of support we should have here. Maybe the patch already gives what you want. Let us know. Thanks.

[Damian]

Thanks Fred... this patch has been verified on our end and looks good.

[Garry Yao]

@garry.yao, I have some doubts about the possibility of supporting your TC. I did some research and I didn't find a good solution that will fit all needs.

Can you check if the new patch is enough for resolving this case?

[Garry Yao]

Original ticket test: ​http://ckeditor.t/tt/7153/1.html
The extended test: ​http://ckeditor.t/tt/7153/2.html

[Frederico Caldeira Knabben]

I would ask to please reconsider patch 1 as it has already been verified. Additionally, the provided tests are not working.

[Garry Yao]

R+ for the first patch, the extended tc opens #8285.

[Garry Yao]

Fixed with [7228].