Opened 13 years ago

Closed 11 years ago

Last modified 11 years ago

#7216 closed Task (wontfix)

Create separate plugin for contentEditable=false

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone:
Component: Core : Read-only Version:
Keywords: Cc:

Description

In order to support correctly contentEditable=false there are a number of additions to the normal code and that means a general performance hit that should required only for those systems where such non-editable elements are being used.

By moving some functions to a separate plugin we can avoid most of the performance hit as well as allowing to keep improving such support without a degradation for the rest of uses.

Attachments (1)

7216.patch (5.9 KB) - added by Alfonso Martínez de Lizarrondo 13 years ago.
Proposed plugin

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by Alfonso Martínez de Lizarrondo

Attachment: 7216.patch added

Proposed plugin

comment:1 Changed 13 years ago by Alfonso Martínez de Lizarrondo

Status: newreview

comment:2 Changed 13 years ago by Garry Yao

Status: reviewreview_failed

The skeleton implementation need to at least handle the per element case, on which some of current (core) plugin relied on, like 'form' plugin.

comment:3 Changed 13 years ago by Alfonso Martínez de Lizarrondo

If it needs to handle at least the per element case, I think that it might be better to leave it as is, and put in the plugin only the changes of the wysiwygarea plugin.

Does that sound right?

comment:4 Changed 11 years ago by Piotrek Koszuliński

Resolution: wontfix
Status: review_failedclosed

I think that the performance hit is inevitable. Especially now, in 4.3, where we had to add code to selection system, styles system and few other places. Separating that code would be hard and would result in situation in which we would have to test two editors. Performance is important, but stability and maintainability have higher priority.

comment:5 Changed 11 years ago by Alfonso Martínez de Lizarrondo

This was a proposal three years ago to start implementing enhanced contentEditable functionality without affecting the rest of the system.

Of course that doesn't make any sense right now.

comment:6 Changed 11 years ago by Piotrek Koszuliński

I know :D But I felt that I need to explain my decision.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy