Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#7216 closed Task (wontfix)

Create separate plugin for contentEditable=false

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone:
Component: Core : Read-only Version:
Keywords: Cc:


In order to support correctly contentEditable=false there are a number of additions to the normal code and that means a general performance hit that should required only for those systems where such non-editable elements are being used.

By moving some functions to a separate plugin we can avoid most of the performance hit as well as allowing to keep improving such support without a degradation for the rest of uses.

Attachments (1)

7216.patch (5.9 KB) - added by alfonsoml 6 years ago.
Proposed plugin

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by alfonsoml

Proposed plugin

comment:1 Changed 6 years ago by alfonsoml

  • Status changed from new to review

comment:2 Changed 6 years ago by garry.yao

  • Status changed from review to review_failed

The skeleton implementation need to at least handle the per element case, on which some of current (core) plugin relied on, like 'form' plugin.

comment:3 Changed 6 years ago by alfonsoml

If it needs to handle at least the per element case, I think that it might be better to leave it as is, and put in the plugin only the changes of the wysiwygarea plugin.

Does that sound right?

comment:4 Changed 4 years ago by Reinmar

  • Resolution set to wontfix
  • Status changed from review_failed to closed

I think that the performance hit is inevitable. Especially now, in 4.3, where we had to add code to selection system, styles system and few other places. Separating that code would be hard and would result in situation in which we would have to test two editors. Performance is important, but stability and maintainability have higher priority.

comment:5 Changed 4 years ago by alfonsoml

This was a proposal three years ago to start implementing enhanced contentEditable functionality without affecting the rest of the system.

Of course that doesn't make any sense right now.

comment:6 Changed 4 years ago by Reinmar

I know :D But I felt that I need to explain my decision.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy