Opened 8 years ago

Last modified 8 years ago

#7230 confirmed Bug

IE quirks: Dialog borders do not resize properly when show/hide tab bar

Reported by: sadlerjw Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.5
Keywords: HasPatch IE Cc:

Description

When the tab bar is being added or removed for a dialog, the resize event is not fired. The resize event is necessary for IE6 or IE quirks mode, since the height of the left and right borders must be adjusted. This can result either in a gap between the top corner borders and the vertical borders on the left and right sides, or the left and right borders extend up above the dialog's title bar. See attached screenshot.

To reproduce:

  1. Create a dialog with two pages. It should display properly, with the tab bar showing.
  2. Hide one of the pages. The tab bar should disappear and you should be able to see the left and right borders extending up above the title bar, as in the screenshot.

This occurs in IE quirks mode...I reproduced across IE6, 7, 8, and 9 with the doctype:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">

A proposed patch is attached. I've changed dialog's resize method to include an optional third parameter, "force," which forces the dialog to fire the resize event even if the actual content area size hasn't changed. Then I call resize from updateStyle, if (and only if) the tab bar visibility has changed AND we're in IE.

Attachments (2)

dialog.jpg (27.2 KB) - added by sadlerjw 8 years ago.
Screenshot of borders extending past title bar in IE9 quirks
7230.patch (1.5 KB) - added by sadlerjw 8 years ago.
Proposed patch

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by sadlerjw

Attachment: dialog.jpg added

Screenshot of borders extending past title bar in IE9 quirks

Changed 8 years ago by sadlerjw

Attachment: 7230.patch added

Proposed patch

comment:1 in reply to:  description Changed 8 years ago by sadlerjw

(In case anyone's wondering, this is a customized Link dialog, which is why there is only one page - and no tabs - visible)

comment:2 Changed 8 years ago by sadlerjw

Component: GeneralUI : Dialogs

...and forgot to tag it as Dialogs. Sorry for the extra updates.

comment:3 Changed 8 years ago by Krzysztof Studnik

Keywords: HasPatch? IE added

comment:4 Changed 8 years ago by Jakub Ś

Status: newconfirmed
Version: 3.5

I have reproduced the issue although I did not modify the dialogs.

  1. Open Skins sample
  2. Go to office or V2 skin
  3. Open link dialog and try to resize it

In IE6, 7 and 8 you don't need a quirks mode to see that borders can't keep up with resizing. In IE9 this is visible only in quirks mode.

Kama skin seems to work fine.

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: HasPatch added; HasPatch? removed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy