Inline Javascript using SRC in the script becomes corrupt on edit

[David Furman]

This can be reproduced by adding an onmousover (or other inline script) with this content: this.src = 'URL';

If the content is edited after the first save, the editor inserts " data-cke-saved-src='URL'" between "this." and "src" in the code.

This breaks the script, and if edited repeatedly, more and more of these strings are inserted into the code.

[Krzysztof Studnik]

Please add info:

• browser and OS used
• more complete sample code, so we could easily reproduce this issue.

[David Furman]

This issue seems to happen in all browsers. The browser that I have personally tested this in and seen the issue are: Chrome 9, Firefox 3.6, IE9 RC, IE 7, IE 8.

Here is HTML to test with:

<p>
	<img _cke_saved_src="http://blog.internetnews.com/skerner/smk/testpilot.png" alt="" onclick="this.src='http://www.textually.org/tv/archives/images/set3/test-pattern-clock_4767.jpg';" src="http://blog.internetnews.com/skerner/smk/testpilot.png" style="width: 360px; height: 327px;" /></p>

Use that as your existing code; when the editor loads it changes it to this broken code:

<p>
	<img _cke_saved_src="http://blog.internetnews.com/skerner/smk/testpilot.png" alt="" onclick="this. data-cke-saved-src='http://www.textually.org/tv/archives/images/set3/test-pattern-clock_4767.jpg' src='http://www.textually.org/tv/archives/images/set3/test-pattern-clock_4767.jpg';" src="http://blog.internetnews.com/skerner/smk/testpilot.png" style="width: 360px; height: 327px" /></p>

Notice the extra data-cke-saved- and the extra image url in single quotes. It seems to be a placeholder, however this is also the same code that is submitted and saved when using submitting the form.

[Wiktor Walc]

Related forum topic: ​http://cksource.com/forums/viewtopic.php?f=11&t=21682

Steps to reproduce

1. Load the following in source mode:

   <p><img onmouseout="this.src='out.png'" onmouseover="this.src='over.png'" src="image.png"></p>
   

2. Switch to wysiwyg mode and back
3. Result:

   <p><img onmouseout="this. data-cke-saved-src='out.png' src='out.png'" onmouseover="this. data-cke-saved-src='over.png' src='over.png'" src="image.png" /></p>
   

[Wiktor Walc]

Issues causing that source code is destroyed should always have higher priority, so targeting it into 3.6.2.

[Sa'ar Zac Elias]

The best way to fix this is probably to simply skip the inline event handlers.

[Sa'ar Zac Elias]

TC added with [7172].

[Frederico Caldeira Knabben]

As for tests, it would be nice to have a proper tt for it, instead of a dt only.

[Sa'ar Zac Elias]

TT added, ​run or ​view source.
Fixed with [7208].