Opened 6 years ago

Closed 6 years ago

#7322 closed Bug (fixed)

Valid font specification not being handled by the editor properly

Reported by: Lynne Kues Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.4
Component: Core : Styles Version: 3.5.2
Keywords: IBM Cc: idzelis@…

Description

Open the editor with the attached html. Click on the various fonts. Notice that the font picker does not recognize the font.

The w3 specification for font-family states that font "family names" must be quoted strings. It specifically "recommends" that fonts with spaces in their name should be quoted, and explicitly shows an example of a font without quotes as invalid.

i.e. (this is specifically mentioned as invalid) font-family: Hawaii 5-0, sans-serif;

See http://www.w3.org/TR/CSS2/fonts.html#font-family-prop

The editor should correctly recognize this type of font specification. In addition, the editor should be generating the font specification according to w3 specification.

Attachments (2)

font-html.txt (445 bytes) - added by Lynne Kues 6 years ago.
7322.patch (913 bytes) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Lynne Kues

Attachment: font-html.txt added

Changed 6 years ago by Garry Yao

Attachment: 7322.patch added

comment:1 Changed 6 years ago by Garry Yao

Component: GeneralCore : Styles
Owner: set to Garry Yao
Status: newreview

Propose for font-family normalization in our styles system:

  1. Dismiss quotes;
  2. Case insensitive (most of the browsers handles font family names that way)

TCs added with [6549].

comment:2 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.5.4
Status: reviewreview_passed

comment:3 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6817].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy