Opened 17 years ago
Closed 17 years ago
#738 closed Bug (fixed)
Cannot change the button type after creating it
| Reported by: | Owned by: | Martin Kou | |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6 |
| Component: | General | Version: | FCKeditor 2.5.1 |
| Keywords: | Confirmed IE Review- | Cc: |
Description
Once inserted, one cannot change the button type of a button in a form anymore.
Steps:
- Insert form - Insert button (type = button) - Open contextmenu of button - Type field is disabled.
Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1501651&group_id=75348&atid=543653
Attachments (1)
Change History (9)
comment:1 Changed 17 years ago by
| Reporter: | changed from Martin Kou to aaronvg@… |
|---|
comment:2 Changed 17 years ago by
| Keywords: | Confirmed IE IE7 added |
|---|---|
| Summary: | Cannot change the button type of a button → Cannot change the button type after creating it |
| Version: | → FCKeditor 2.5.1 |
comment:3 Changed 17 years ago by
| Keywords: | IE7 removed |
|---|
comment:4 Changed 17 years ago by
| Owner: | set to Martin Kou |
|---|---|
| Status: | new → assigned |
Changed 17 years ago by
comment:6 Changed 17 years ago by
| Keywords: | Review? added |
|---|---|
| Milestone: | → FCKeditor 2.6 |
comment:7 Changed 17 years ago by
| Keywords: | Review- added; SF Review? removed |
|---|
That code would lose any other property that isn't handled by this dialog (like class, style or any event handler). It might not be common, but it is a possibility. So I Review- because that's data loss.
In #676 I added the code to handle also this issue, but there are some ideas (like not creating a new element if the special properties haven't changed) in this patch that I must apply.
Note: See
TracTickets for help on using
tickets.
Confirmed on IE and IE7. In FF the problem is bigger because you can't access the button properties. See #703.