Overrides of Styles don't work correctly for classes

[Alfonso Martínez de Lizarrondo]

Load the XHTML output sample.[br] Select a word an apply for example the Comic font to it. Now select Times New Roman

Expected results:[br] A single span that makes the text appear in Times New Roman.

Actual results:[br] Two nested spans with and the text is shown in Comic.

This is the way that the font styles are defined for that sample:

font_style :
{
		element		: 'span',
		attributes		: { 'class' : '#(family)' },
		overrides	: [ { element : 'span', attributes : { 'class' : /^Font(?:Comic|Courier|Times)$/ } } ]
},

As the "element" is the same one that it's used in the overrides definition it seems to be cause of the problems.

The patch fixes this problem, but there might be better ways to fix it if it was planned in a different way (and there might be other places to review)

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Frederico Caldeira Knabben]

Tests for the tests branch.

[Frederico Caldeira Knabben]

I'm attaching a test for this case.

While we need to work on an overall review on the styles system, the proposed patch seems to properly fix this case. It looks logic "enough".

[Alfonso Martínez de Lizarrondo]

Fixed with [6983]

[Wiktor Walc]

Reverted with [7061] due to #8078.

[Garry Yao]

The overrides definitions in the xhtml_output sample page is reverted with [7062].

[Alfonso Martínez de Lizarrondo]

New patch

[Alfonso Martínez de Lizarrondo]

The new patch restores the xhtml sample and fixes #8078 by calling removeOverrides with a new parameter (so it doesn't affect the rest of the code) when the element is a block type so it isn't removed.

This way we avoid nesting spans as the first patches did and we remove the element only when it's an inline and we don't have left over spans without attributes.

[Frederico Caldeira Knabben]

Appended dt:
​http://ckeditor.t/dt/plugins/styles/styles.html

[Frederico Caldeira Knabben]

#8078 is still regressed with the new patch (​its test also fails).

[Alfonso Martínez de Lizarrondo]

Revised patch

[Alfonso Martínez de Lizarrondo]

Sorry, don't know what I tested before creating the patch but it was obviously wrong.

[Alfonso Martínez de Lizarrondo]

Fixed with [7407]