#7584 closed Bug (fixed)
Start Value not shown correctly for Numbered lists Paste from Word
Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.1 |
Component: | Plugin : Paste from Word | Version: | 3.5.3 |
Keywords: | IBM | Cc: | Damian, James Cunningham, Teresa Monahan |
Description
To reproduce the defect:
- Copy the list from attached word doc and paste it using Paste from Word dialog.
- Check for the Start value for the list in Numbered List Properties dialog.
Expected Result: It should show start value as 5.
Actual Result: It shows start value as 1.
- Try to change the Start Value to 10 and press OK button.
Expected Result: Numbered list should start at 10.
Actual Result: Numbered list still start at 5.
Attachments (4)
Change History (16)
Changed 14 years ago by
Attachment: | Numbered list with diff start value.doc added |
---|
comment:1 Changed 14 years ago by
Cc: | damo,jamescun,tmonahan → damo, jamescun, tmonahan |
---|---|
Component: | General → UI : Dialogs |
Status: | new → confirmed |
Changed 14 years ago by
Attachment: | 7584.patch added |
---|
comment:2 Changed 14 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | confirmed → review |
Type: | Bug → New Feature |
comment:3 Changed 14 years ago by
Status: | review → review_failed |
---|---|
Type: | New Feature → Bug |
- The "List Item Properties" dialog, even if useful, goes out of the scope of this ticket. I think we have another ticket for it and it should be handled there (or in a new ticket). Additionally, it doesn't represent a fix for the problem.
- In the eyes of the end user, it doesn't matter if the start number has been set in the list or in the list item directly. Because of this, the List Properties dialog must show the start number accordingly. This ticket is in fact limited to this issue.
Changed 14 years ago by
Attachment: | 7584_2.patch added |
---|
comment:4 Changed 14 years ago by
Status: | review_failed → review |
---|
The "List Item Properties" dialog moves to #7853.
comment:5 Changed 14 years ago by
Status: | review → review_failed |
---|
I see that you have now moved the start number attribute from the list item to the list, which is definitely good.
My only concern is that it may still give a bad user experience if "value" is set on all list items. When the user changes the start value in the dialog, only the first item get changed, while the others remain intact. This happens with the second list in the reported TC.
What about removing the "value" attribute from the list items if they are sequential?
comment:6 Changed 14 years ago by
Um...not sure as "value" set on all list items are pretty much a rare case as the property is mainly used to break consequential numbering. In any case, here we're talking about the "start" number of the entire list which should not get affiliated with per list item numbering.
comment:7 Changed 14 years ago by
The rare case that makes it weird, justifying this simple fix.
The idea is quite simple... if the users sees: 5, 6, 7, etc.... if the start number changes to 10, we'll have: 10, 11, 12, etc., which sounds quite natural.
Basically, we're talking about changing *sequential* values only.
We're talking about the behavior of the "start" field in the dialog, so all this is definitely related, considering that the change on the field will change all values.
Changed 14 years ago by
Attachment: | 7584_3.patch added |
---|
comment:8 Changed 14 years ago by
Status: | review_failed → review |
---|
comment:10 Changed 14 years ago by
Milestone: | → CKEditor 3.6.1 |
---|---|
Status: | review → review_passed |
comment:11 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6976].
comment:12 Changed 11 years ago by
Component: | UI : Dialogs → Plugin : Paste from Word |
---|
I didn't figure out any appropriate design (context-based) of reusing the same menu item for editing both list and items, so a small submenu is introduced, which consist of both the options.