Opened 14 years ago
Closed 14 years ago
#7752 closed Bug (fixed)
Styles toolbar items need to use role="presentation" on all spans
Reported by: | Damian | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6 |
Component: | Accessibility | Version: | |
Keywords: | IBM | Cc: | Satya Minnekanti, Teresa Monahan, James Cunningham |
Description
The current markup for cke_rcombo items has
<span class="cke_rcombo"> <span class="cke_styles"> <a role="button"> </span> </span>
When using INS+TAB in JAWS to re-read the currently focused item, JAWS doesn't read the parent toolbar name. If role="presentation" is applied to the two <spans>, JAWS will read them correctly.
So we need this:
<span class="cke_rcombo" role="presentation"> <span class="cke_styles" role="presentation"> <a role="button"> </span> </span>
Attachments (1)
Change History (6)
comment:1 follow-up: 2 Changed 14 years ago by
Status: | new → pending |
---|---|
Version: | 3.6 (SVN - 3.6.x) |
comment:2 Changed 14 years ago by
Replying to garry.yao:
In which browser did you have this observed? I got everything works fine in FF while in IE the toolbar name is missing even apply your patch.
we were using ff3.6.16 and JAWS 12. It reads properly when you enter the Toolbar group for the first time, but when you press INS+TAB to make JAWS read the item again, it's not reading the parent tool bar name(Styles). This is working for all other toolbars.
Changed 14 years ago by
Attachment: | 7752.patch added |
---|
comment:3 Changed 14 years ago by
Milestone: | → CKEditor 3.6 |
---|---|
Owner: | set to Frederico Caldeira Knabben |
Status: | pending → review |
I was able to confirm the issue with the v2 and office2003 skins only. Sounds like a JAWS issue, but the proposed fix solves the problem, in fact.
The patch is targeted to the 3.6.x branch.
comment:4 Changed 14 years ago by
Status: | review → review_passed |
---|
Weird enough, skins have the same toolbar structure though...
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6804].
In which browser did you have this observed? I got everything works fine in FF while in IE the toolbar name is missing even apply your patch.