Ticket #7894 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Pasting links in IE8 and IE9 no longer working as expected

Reported by: tmonahan Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.6.2
Component: Core : Parser Version: 3.5.3
Keywords: IBM Cc: damo, satya, jamescun

Description

When pasting links into CKEditor, IE automaticcaly detects the links and converts them into anchor tags. Although the HTML IE generates for this is mal-formed, this used to work quite well in CKEditor. However from 3.5.3 onwards there is a change in this behaviour and extra links are now generated for the pasted content in IE8 and IE9.

To see an example of this, paste the following content (which was generated by IE) into the source view of CKEditor in 3.5.2 and then in 3.5.3. Then switch back to wysiwyg editor and see that the first word on line 2 has been incorrectly converted to a link in the 3.5.3 version.

<P>line 1 <A href="http://www.ibm.comline"><a href="http://www.ibm.com">http://www.ibm.com</a></P>
<P>line</A> 2 <A href="http://ckeditor.com"><a href="http://ckeditor.com">http://ckeditor.com</a></A></P>

We realise that this is essentially a browser issue since the HTML generated is not valid. However we would be interested to know why there is a difference in behaviour between the 2 CKEditor versions. Was there a code change in this area to address another issue? Also, do you think there is any way we could potentially work around this browser limitation for CKEditor 3.5.3 onwards? Any thoughts or comments you have on this would be greatly appreciated.

Attachments

7894_TC.patch (750 bytes) - added by garry.yao 3 years ago.
7894.patch (1.2 KB) - added by garry.yao 3 years ago.
7894_2.patch (1.6 KB) - added by garry.yao 3 years ago.

Change History

comment:1 Changed 3 years ago by j.swiderski

  • Status changed from new to confirmed

"line 2" has been converted in to link in Opera, IE8 and IE9 from CKEditor 3.5.3 rev [6561]

Changed 3 years ago by garry.yao

Changed 3 years ago by garry.yao

comment:2 Changed 3 years ago by garry.yao

  • Status changed from confirmed to review
  • Owner set to garry.yao

Link (with href attribute) is to be removed when empty.

comment:3 Changed 3 years ago by garry.yao

  • Component changed from General to Core : Parser

comment:4 follow-up: ↓ 5 Changed 3 years ago by fredck

  • Keywords NeedsTest added

We need a ticket test branch here.

comment:5 in reply to: ↑ 4 ; follow-up: ↓ 7 Changed 3 years ago by garry.yao

  • Keywords NeedsTest removed

Replying to fredck:

We need a ticket test branch here.

Already had one there, but on that branch a dt was forked instead of a tt.

comment:6 Changed 3 years ago by fredck

Good to know... enough to point to the test file:
http://ckeditor.t/dt/core/htmlparser/fragment.html

comment:7 in reply to: ↑ 5 Changed 3 years ago by fredck

  • Status changed from review to review_failed

Replying to garry.yao:

Already had one there, but on that branch a dt was forked instead of a tt.

That is proving to be a problem. While the patch fixes the dt test, it makes no difference for the issue reported here.

A tt is definitely needed.

Changed 3 years ago by garry.yao

comment:8 Changed 3 years ago by garry.yao

  • Status changed from review_failed to review

comment:10 Changed 3 years ago by fredck

  • Status changed from review to review_passed

The following test was failing after patch and has been fixed on the ticket branch:
http://ckeditor.t/tt/4614/1.html

comment:11 Changed 3 years ago by fredck

  • Milestone set to CKEditor 3.6.2

comment:12 Changed 3 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [7223].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy