#7981 closed Bug (fixed)
Iframe dialog not picking width & height values entered in source view
| Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.1 |
| Component: | General | Version: | 3.6.1 |
| Keywords: | IBM | Cc: | Damian, James Cunningham, Teresa Monahan |
Description
To reproduce the defect:
- Copy an embed code for a video from you tube and paste in to Source view. use the following example:
<iframe width="560" height="349" src="http://www.youtube.com/embed/39jtNUGgmd4" frameborder="0" allowfullscreen></iframe>
- Go to Rich text, open context menu on the IFrame & click on Iframe Properties option.
Expected Result: Iframe Properties dialog comes up and shows values of 560px & 349px for width & height fields and also the style field on Advanced tab should show width: 560px; height: 349px.
Actual Result: Iframe Properties dialog comes up but width & height fields are shown empty & also style field on Advanced tab is shown empty.
Attachments (2)
Change History (15)
comment:1 Changed 14 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 14 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 14 years ago by
Another issue related to this defect is after step 2 when we press OK button with out modifying any values, initial values for width & height are removed and it is restoring IFrame to default height & width
Changed 14 years ago by
| Attachment: | 7981.patch added |
|---|
comment:4 Changed 14 years ago by
| Status: | assigned → review |
|---|
Propose to revert [6958] to separate styles and attribute-based dimension for now.
comment:5 follow-up: 6 Changed 14 years ago by
I also think we should revert [6958], considering that the it's also not working as expected.
The patch does not seem to be correct though (it contains changes for _source/core/htmlparser/element.js, _source/plugins/fakeobjects/plugin.js and so on)
comment:6 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Replying to wwalc:
I also think we should revert [6958], considering that the it's also not working as expected.
That refers to #7933.
I think reverting the sync is enough, we don't need to bloat the code right now with different stuff (out of the scope, we have #7958 for that).
comment:7 Changed 14 years ago by
| Milestone: | → CKEditor 3.6.1 |
|---|
comment:8 Changed 14 years ago by
Just fake object changes are just to make things simpler, but well...we can void them at the moment, besides, I've noticed another regression from [6979] which makes it more than reverting [6958]:
- With the ticket tc, but don't open dialog;
- Switch to source after load in wysiwyg;
- Px units are appended to attribute values
Changed 14 years ago by
| Attachment: | 7981_2.patch added |
|---|
comment:9 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:10 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:11 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [7012].
comment:12 Changed 14 years ago by
Even though width & height fields on General Tab showing correct values but the style field on Advanced tab is still empty. Please re open this ticket
True from rev [6958]