Opened 8 years ago

Last modified 3 years ago

#7995 confirmed New Feature

IFrame dialog Style field in Advanced tab not reflecting values entered for Width & Height in General tab

Reported by: Satya Minnekanti Owned by:
Priority: Normal Milestone:
Component: General Version: 3.5
Keywords: IBM Cc: Damian, Teresa Monahan

Description

To reproduce the defect:

  1. Open CK Editor,click on IFrame icon to open IFrame Properties dialog.
  1. On General tab enter values for width(200)& Height(100) and click on Advanced tab.

Expected Result: Style field should have following values width: 200px; height: 100px;

Actual Result: Style field is empty.

Change History (8)

comment:1 Changed 8 years ago by Wiktor Walc

Keywords: Discussion added
Type: BugNew Feature
Version: 3.6.1 (SVN - trunk)3.5

Unlike tables and images, the dimensions of iframe element are currently set using attributes.

Unless we start using also CSS styles for setting height and width of the iframe element, I don't think that filling the style field automatically is the right solution.

We have another ticket where a generic approach for this problem is discussed: #7958

comment:2 Changed 8 years ago by Garry Yao

Same with the flash dialog, we should close this ticket as wontfix.

comment:3 Changed 8 years ago by Teresa Monahan

Apart from the dialog fields not being updated as described in the above steps, the placeholder for the iframe does not reflect the width and height set through the styles field on the advanced tab. This is a regression of #7158.

comment:4 Changed 8 years ago by Wiktor Walc

@tmonahan - it's a separate issue (#7933), as explained by Saare in comment:10. Not a recent regression, it was working this way since the beginning.

comment:5 Changed 8 years ago by Teresa Monahan

@wwalc - The usecase in #7158 no longer works even if the OK button is clicked when the user is on the General tab. Therefore I believe it is a different issue to #7933. In the usecase from #7158, the image placeholder never gets assigned width and height values from the styles field. When previewd, the actual iframe does get assigned the styles css values though.

comment:6 Changed 7 years ago by Teresa Monahan

I cannot reproduce the issue in ticket #7933 on 3.6.x trunk. Perhaps it has been indirectly fixed. However I can still reproduce the issue discussed in this ticket. This was previously fixed in changeset [6958] for ticket #7158 but the problem is occurring again. The width and height fields on the General tab are not synched with the styles field on the Advanced tab. Also width/height styles set through the Advanced tab are not reflected by the placeholder image.

comment:7 Changed 6 years ago by Jakub Ś

Keywords: Discussion removed
Status: newconfirmed

This is still happening in latest CKEditor 4.2. One style doesn't update other.

I was able to reproduce this problem from CKEditor 3.5 (when iframe plugin was introduced).

comment:8 Changed 3 years ago by Anna Tomanek

Summary: IFrame dialog Style field on Advanced tab not reflecting values entered for width & height on General TabIFrame dialog Style field in Advanced tab not reflecting values entered for Width & Height in General tab
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy