Opened 12 years ago
Closed 12 years ago
#8036 closed Bug (fixed)
Inconsistent handling of height and width values
| Reported by: | Sa'ar Zac Elias | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.1 |
| Component: | UI : Dialogs | Version: | 3.6.1 |
| Keywords: | Cc: | satya_minnekanti@… |
Description
- Insert an iframe with width=200, height=300.
- RMB on it, open the iframe dialog. See that it shows width=200px, height=300px.
- Switch to source and back.
- RMB on the iframe, open the iframe dialog. See that now it shows width=200, height=300.
Attachments (1)
Change History (10)
comment:1 Changed 12 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → assigned |
Changed 12 years ago by
| Attachment: | 8036.patch added |
|---|
comment:3 Changed 12 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 12 years ago by
| Cc: | satya_minnekanti@… added |
|---|
comment:5 Changed 12 years ago by
| Status: | review → review_failed |
|---|
Actually when dimensions are specified via styles, these are the ones to use, as per browsers rendering.
comment:6 Changed 12 years ago by
Sorry, that was not related to the patch.
The two forms should be distinguished on input as well, as currently width="200px" is (wrongly) converted into width="200".
And a small one, please fix coding style in the new htmlParser::cssStyle codes.
comment:7 Changed 12 years ago by
| Status: | review_failed → review |
|---|
This turns out to be an IE limitation instead, where the DOM swallows the "px" units on attributes, works well for all the rest of browsers, we can hardly fix it.
comment:8 Changed 12 years ago by
| Status: | review → review_passed |
|---|
Make sure to fix coding style in the new htmlParser::cssStyle codes before committing.
comment:9 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [7050:7051].
Note: See
TracTickets for help on using
tickets.
Regression of [7012].