Opened 12 years ago

Closed 12 years ago

#8155 closed Bug (fixed)

Special Character dialog window shows the same tooltip for symbols with different spelling case

Reported by: Satya Minnekanti Owned by: Anna Tomanek
Priority: Normal Milestone: CKEditor 3.6.2
Component: General Version: 3.5
Keywords: IBM Cc: Damian, Teresa Monahan

Description (last modified by Anna Tomanek)

To reproduce the defect:

  1. Open any CK Editor sample and open Special Character dialog.
  1. Hover your mouse over the two icons next to bullet in last row

Issue: They both have same label Rightwards double arrow.

The same goes for some pairs of letters, capital & small, like Œ and œ, for example.

Attachments (1)

8155.patch (7.9 KB) - added by Anna Tomanek 12 years ago.
Proposed patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by Jakub Ś

Status: newconfirmed
Version: 3.5

comment:2 Changed 12 years ago by Anna Tomanek

Description: modified (diff)
Summary: Both special characters have same label on Special Character dialogSpecial Character dialog window shows the same tooltip for symbols with different spelling case

The correct definitions, as per Unicode names, should be "Rightwards arrow" (for →) and "Rightwards double arrow" (for ⇒).

The error, however, stems from the fact that the editor does not differentiate between spellings with different case.

For arrows there should be two separate definitions for that in the specialchar/lang/en.js file and the editor should take letter case (rarr vs rArr) into account. This is a general problem, however, and more definitions are affected, like Œ and œ (Latin capital ligature oe and Latin small ligature oe) etc., so I am updating the ticket title.

We also seem to be missing the definitions for capital letters, or, in other words, all symbols with entities containing a capital letter (Ugrave, OElig) are missing from the lang/en.js file.

Changed 12 years ago by Anna Tomanek

Attachment: 8155.patch added

Proposed patch

comment:3 Changed 12 years ago by Anna Tomanek

Owner: set to Anna Tomanek
Status: confirmedreview

Attached is the patch with the following changes:

  1. Added missing descriptions for entities that contained capital letters.
  2. Added a few missing descriptions for entities like > and &.
  3. Removed the two redundant "&" character entries from the list (just & is left).
  4. Removed the toLowerCase() method from plugin code.

comment:4 Changed 12 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

Just note that for chracters which include grave or actue accents, the word accent is omitted for the small letters, while it is present in the capital letters.

comment:5 Changed 12 years ago by Wiktor Walc

Milestone: CKEditor 3.6.2

comment:6 Changed 12 years ago by Anna Tomanek

Resolution: fixed
Status: review_passedclosed

Fixed with [7164]. Thanks for the tip, Saar, corrected all entries.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy