Undo not working properly

[Satya Minnekanti]

Scenario 1:

1. Open Ajax sample and type the following sentence ( This is test sentence.) and click on Insert Horizontal line icon.

2. See that Horizontal line is inserted after current paragraph.

3. Now click on Undo icon once.

Expected Result: Horizontal line inserted in step 2 should be removed & cursor should stay at end of paragraph typed in step 1.

Actual Result: It removes Horizontal line as well as most of text in the paragraph we typed in step 1 and also it disables the Undo button

Scenario 2:

1. Open Ajax sample and type the following sentence ( This is test sentence.) select the sentence and apply a Paragraph Format option( for ex: Heading 1).

2. See that Heading 1 paragraph format applied to selected paragraph.

3. Now click on Undo icon once.

Expected Result: Heading 1 paragraph format applied to selected paragraph is removed.

Actual Result: It removed the whole paragraph along with Heading 1 paragraph format.

This has been happening from rev 7225

[Jakub Ś]

Reproducible from rev [7225]

[Garry Yao]

​http://ckeditor.t/tt/8299/1.html

[Garry Yao]

Fixed with [7252].

[Satya Minnekanti]

This is still notproperly fixed. Please reopen the ticket. Below scenarios do not work.

Open Ajax sample and paste the following code in source.

<p>
	first paragraph</p>
<ol>
	<li>
		list one</li>
	<li>
		list two.</li>
</ol>
<p>
	second paragraph</p>

Go to rich text, select entire text by using Ctrl + A or select the list and one or both the paragraphs & click on Delete or Backspace button.

see that the selected content is removed.

Now click on Undo icon or press Ctrl + z

Expected Result: Deleted text comes back

Actual Result: Deleted text will never come back no matter how many times we press Undo

[Satya Minnekanti]

Scenario 2 Open any CK Editor sample and paste the following code in source.

<p>
	111111111111111111111 5555555555555555555 7777777777777777777777777777777777</p>
<p>
	000000000000000000000000000000 33333333333333333333333333333333 22222222222222222222222222222222222222 8888888888888888888888888888888888888</p>

Go to rich text, select entire text by using Ctrl + A & click Delete or Backspace button.

see that the selected content is removed.

Now click on Undo icon or press Ctrl + z

Expected Result: Deleted text comes back

Actual Result: Deleted text will never come back no matter how many times we press Undo

[Jakub Ś]

Still reproducible from rev [7225]

[Garry Yao]

Replying to garry.yao:

​http://ckeditor.t/tt/8299/1.html

TC is enlarged to include tc provided at above comment.

[Garry Yao]

I realized the timeout change in [7225] was a bad move, as the closure will read an outdated selection state which will cause some chaos in cursor position, eventually cause #8337.

[Garry Yao]

Re-fixed with [7255].