Opened 13 years ago
Last modified 8 years ago
#8307 confirmed Bug
[iOS] Maximize is broken
Reported by: | Frederico Caldeira Knabben | Owned by: | |
---|---|---|---|
Priority: | Nice to have (we want to work on it) | Milestone: | |
Component: | General | Version: | 3.6.2 |
Keywords: | iOS | Cc: |
Description
When Maximizing, the editor toolbar go out of the viewport boundaries, making it impossible to use the editor and restore the size to use the page.
Change History (31)
comment:1 Changed 13 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 13 years ago by
Version: | → 3.6.2 (SVN - trunk) |
---|
comment:4 Changed 11 years ago by
Summary: | iOS: Maximize is broken → [iOS] Maximize is broken |
---|
comment:5 Changed 10 years ago by
It's been four years since Maximize was disabled on iOS and it's still not enabled... is it still broken, even on iOS 8? I have clients that would really appreciate being able to maximize the editor.
comment:6 Changed 10 years ago by
I have tested it right now, and the situation is better only on the bigger screen.
On iPad editor works fine in the maximize mode. The toolbar is visible and available. The only problem is that if keyboard appears editor is scrolled so the toolbar is above the viewport and I need to scroll it back, what it not that big deal, but if editor would resize instead, the experience would be perfect.
On iPod it is broken as it was before.
On both devices I had iOS 8.3 with mobile Safari 8 (AppleWebKit/600.1.4).
We could consider re-enabling it on the iPad.
comment:7 Changed 9 years ago by
Owner: | set to Szymon Cofalik |
---|---|
Status: | confirmed → assigned |
comment:8 Changed 9 years ago by
After extensive week of trying to fix current maximize solution to fit iPad quirks I have to surrender, because hacking one bug lead to another one. Unfortunately, handling iframe that fills whole viewport and is scrollable is difficult. When keyboard is shown, it makes original viewport scrollable too, so we have a scrollable window in a scrollable window.
I tried to fit iframe's height to be viewport height
minus iOS keyboard height
and partially managed to do so. However, the viewport was still scrollable (it had "empty" html
element behind it and it was possible to still scroll down). AFAIR I managed to fix this behavior by preventing scroll event when editor reached certain scroll and when screen was touched at too low position.
Then other problems occured: iframe's scroll started to jump all over the place when typing letters. I haven't found a good solution for the last problem that didn't introduce heavy UX flaws and at that point the code was really messy and hacked so I come to conclusion that it is not worthy to go even deeper this way.
There is other possible solution to maximize on iPad. We cold make the iframe's width 100% of the viewport and set height like autogrow plugin does - height would be big enough to show all contents. Then we would use viewport's scrollbar for scrolling and iframe wouldn't have any scrollbar. Maybe in this approach we would get rid of some problems and this would result in correct working of maximize plugin on iPad. However, it needs further research.
Right now I am only pushing what @pjasiun suggested: I enable maximize plugin for iPads. It is usable but I wouldn't expect good user experience. branch:t/8307.
comment:9 Changed 9 years ago by
There is other possible solution to maximize on iPad. We cold make the iframe's width 100% of the viewport and set height like autogrow plugin does - height would be big enough to show all contents. Then we would use viewport's scrollbar for scrolling and iframe wouldn't have any scrollbar. Maybe in this approach we would get rid of some problems and this would result in correct working of maximize plugin on iPad. However, it needs further research.
I'm super interested in results of this research. We can accept branch:t/8307 for now and perhaps for the rest of CKE 4.x's life, but we'll need a better, more stable, simpler in terms of code and hence more predictable solution for CKE5. Therefore please give it a try. I think that some mockups would be a good start.
comment:10 Changed 9 years ago by
Milestone: | → CKEditor 4.5.2 |
---|---|
Owner: | changed from Szymon Cofalik to Piotrek Koszuliński |
Status: | assigned → review |
comment:11 Changed 9 years ago by
I've pushed branch:t/8307-new.
On this branch I included a prototype of solution where maximize
acts like autogrow
. It's nowhere near to a final solution and it is not integrated with autogrow
(I think that would be profitable -- instead of copying similar parts of code). However this is a good starting point to see how iPad behaves (and try to fix it's quirks).
I think that it looks promising.
The big struggle with iPad is that it enables scrolling of iframe even if iframe's contents are smaller than the iframe itself. If we manage to overcome this behavior without introducing other bugs we will have easy time with the rest of the plugin.
comment:12 Changed 9 years ago by
Milestone: | CKEditor 4.5.2 → CKEditor 4.5.3 |
---|
comment:13 Changed 9 years ago by
Milestone: | CKEditor 4.5.3 → CKEditor 4.5.4 |
---|---|
Owner: | changed from Piotrek Koszuliński to Olek Nowodziński |
Status: | review → assigned |
This is quite a story and it still requires hours of research and prototyping. I don't think we'll be able to release a stable solution any time soon.
comment:14 Changed 9 years ago by
Milestone: | CKEditor 4.5.4 → CKEditor 4.5.5 |
---|
comment:15 Changed 9 years ago by
Milestone: | CKEditor 4.5.5 → CKEditor 4.5.6 |
---|
comment:16 Changed 9 years ago by
Milestone: | CKEditor 4.5.6 → CKEditor 4.5.7 |
---|
comment:17 Changed 9 years ago by
Milestone: | CKEditor 4.5.7 → CKEditor 4.5.8 |
---|
comment:18 Changed 9 years ago by
Milestone: | CKEditor 4.5.8 → CKEditor 4.5.9 |
---|
comment:19 Changed 9 years ago by
Milestone: | CKEditor 4.5.9 → CKEditor 4.5.10 |
---|
comment:20 Changed 8 years ago by
Milestone: | CKEditor 4.5.10 → CKEditor 4.5.11 |
---|
Moving tickets to the next milestone.
comment:21 Changed 8 years ago by
Milestone: | CKEditor 4.5.11 → CKEditor 4.6.1 |
---|---|
Owner: | Olek Nowodziński deleted |
Status: | assigned → confirmed |
comment:22 follow-up: 24 Changed 8 years ago by
Milestone: | CKEditor 4.6.1 |
---|
Removing from milestone. There's no strong demand for this issue from our community so it has a lower priority.
comment:24 Changed 8 years ago by
Replying to m.lewandowski:
Removing from milestone. There's no strong demand for this issue from our community so it has a lower priority.
sorry to bother but is there any way to enable maximize on iphone?
comment:26 Changed 8 years ago by
Hi! We've been waiting for this feature to be fixed for a while now, Have you got any updates? Are you planning on fixing it soon?
comment:27 follow-up: 28 Changed 8 years ago by
I'll put it once again on our backlog, we'll see if there's something reasonable we can do about it. But looking at past history it's not going to be a trivial task. Can't provide you with any precise ETA though.
comment:28 Changed 8 years ago by
Replying to m.lewandowski:
I'll put it once again on our backlog, we'll see if there's something reasonable we can do about it. But looking at past history it's not going to be a trivial task. Can't provide you with any precise ETA though.
Thanks for that! The fact that it'll be back on your backlog gives us some hope!
I'll pay attention to the ticket updates.
comment:29 Changed 8 years ago by
Priority: | Normal → Nice to have (we want to work on it) |
---|
comment:30 follow-up: 31 Changed 8 years ago by
I can also note that mobile support (including full screen) is in our area of interest in upcoming CKEditor 5, you'll find more on that in UX: Mobile editing issue.
comment:31 Changed 8 years ago by
Replying to m.lewandowski:
I can also note that mobile support (including full screen) is in our area of interest in upcoming CKEditor 5, you'll find more on that in UX: Mobile editing issue.
Thanks, I will keep an eye on it.
Confirmed with iOS 5 Beta 6.