Opened 6 years ago

Closed 6 years ago

#8329 closed New Feature (duplicate)

Ability to support vbox layout for Radio buttons in dialogs

Reported by: Henrik Helmø Larsen Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version:
Keywords: Cc:

Description

It would be nice to allow radio buttons to be able to use vbox layout instead of the hardcoded hbox-layout.

This can be done by inserting the following code:

if ( elementDefinition.labelLayout != 'horizontal' )
  new CKEDITOR.ui.dialog.vbox( dialog, [], inputHtmlList, html );
else
  new CKEDITOR.ui.dialog.hbox( dialog, [], inputHtmlList, html );

instead of:

new CKEDITOR.ui.dialog.hbox( dialog, [], inputHtmlList, html );

In version 3.6.1 the code that has been changed is in line 479 of plugins.js under the dialogui folder.

It is then possible - when creating the radiobutton group in the dialog to use:

labelLayout: "vertical"

By writing the code in the above way it would be backward compatible using the hbox layout if nothing is defined - but if anything else than "horizontal" is used, vbox layout will be used instead.

I hope you will include this "minor" change so I don't manually have to insert it in the code for every update of CKEDITOR ;-)

Change History (1)

comment:1 Changed 6 years ago by Jakub Ś

Resolution: duplicate
Status: newclosed

This is a DUP of #5094.

@Helmø - Since you are proposing a fix to this issue I will paste your comment in #5094.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy