Opened 6 years ago

Closed 6 years ago

#8699 closed Bug (fixed)

Focus not going back to correct field on Cell Properties after we close Select Color dialog using OK & Cancel buttons

Reported by: Satya Minnekanti Owned by: Piotrek Koszuliński
Priority: Normal Milestone:
Component: General Version: 3.4.1
Keywords: IBM HasPatch Cc: Damian, Teresa Monahan

Description

To reproduce the defect:

  1. Open any CK Editor sample & insert a table.
  1. Open Content menu and click on Cell -> Cell Properties option.
  1. Cell Properties dialog opened.
  1. Click on Choose button next to Background Color.
  1. Select Color dialog opened.

Scenario 1:

Select a color in the Color list box and press OK button.

Expected Result: Select Color dialog closed, selected color gets applied to Background color and focus should go back to Choose button next to Background Color text field.

Actual Result: Select Color dialog closed, selected color gets applied to Background color but focus going to next field which is Border Color text field.

Scenario 2:

Select a color in the Color list box and press Cancel button.

Expected Result: Select Color dialog closed, no color applied to Background color and focus should go back to Choose button next to Background Color text field.

Actual Result: Select Color dialog closed, no color applied to Background color but focus going back to Background Color text field instead of Choose button next to it.

Same issue happens when we select Border Color and click OK & Cancel buttons on Select Color dialog

Focus going to next field after Choose button when we click OK button to close Select Color dialog

Focus going to previous field before Choose button when we click Cancel button to close Select Color dialog

Attachments (2)

8699.patch (3.5 KB) - added by Piotrek Koszuliński 6 years ago.
8699_2.patch (3.5 KB) - added by Piotrek Koszuliński 6 years ago.
Fixed coding style for last patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed
Version: 3.4.1

Reproducible in all browsers from CKEditor 3.4.1

comment:2 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

Changed 6 years ago by Piotrek Koszuliński

Attachment: 8699.patch added

comment:3 Changed 6 years ago by Piotrek Koszuliński

Keywords: HasPatch added
Status: assignedreview

comment:4 Changed 6 years ago by Garry Yao

Status: reviewreview_passed

There's a coding style issue at _source/plugins/dialogui/plugin.js#L979 pls fix that on commit.

Please make sure a changelog entry is committed along with the patch as well.

Changed 6 years ago by Piotrek Koszuliński

Attachment: 8699_2.patch added

Fixed coding style for last patch

comment:5 Changed 6 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed with [7364].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy