Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#8698 closed Bug (fixed)

Can't close Select Colour dialog using Esc

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.3
Component: Accessibility Version: 3.0.1
Keywords: IBM Cc: Damian, Teresa Monahan

Description

To reproduce the defect:

  1. Open any CK Editor sample & insert a table.
  1. Open Content menu and click on Cell -> Cell Properties option.
  1. Cell Properties dialog opened.
  1. Click on Choose button next to Background Color or Border Color text field.
  1. Select Colour dialog opened.
  1. Now press Esc.

Expected Result: Select Color dialog closed & focus goes back to Choose button next to Background Color or Border Color text field.

Actual Result: Select Color dialog not closed.

Attachments (1)

8698.patch (1.2 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Jakub Ś

Component: GeneralAccessibility
Status: newconfirmed
Version: 3.0.1

Reproducible in all browsers from CKEditor 3.0.1

comment:2 Changed 6 years ago by Jakub Ś

Other tickets that fall under Select "Color Dialog Problems / Enchancements":
#8706, #8701, #8519, #8679, #8523, #8218, #5960, #4994.

Changed 6 years ago by Garry Yao

Attachment: 8698.patch added

comment:3 Changed 6 years ago by Garry Yao

Milestone: CKEditor 3.6.3
Owner: set to Garry Yao
Status: confirmedreview

comment:4 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

Just to make it confusing, please remove "Also register key handlers if first dialog" comment line when committing.

comment:5 Changed 5 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7370] and [7371].

comment:6 Changed 5 years ago by Satya Minnekanti

I could still reproduce this issue on nightly build & i can't close Select Colour dialog using Esc key. Please re-open this defect.

comment:7 Changed 5 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: closedreopened

Confirmed, I can reproduce it with FF by following the ticket tc. It works well only when opening the dialog directly through the color buttons in the toolbar.

comment:8 Changed 5 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

It's mistake, that only part of the patch (#8701) was committed, compensate the commit with [7408].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy