Opened 13 years ago
Closed 13 years ago
#8812 closed Bug (fixed)
IE9: HTML comment blocks Enter Key
| Reported by: | Jakub Ś | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.3 |
| Component: | Core : Selection | Version: | 3.0 |
| Keywords: | IE9 | Cc: |
Description
- open the http://ckeditor.com/demo/ in IE9
- press source button to switch to source mode.
- remove all default contents.
- input this line.
test <!-- --> - press source button and switch to WYSIWYG mode.
- Click in editor (doesn't matter where) and press Enter key.
Result: Enter key does not work.
Attachments (3)
Change History (13)
comment:1 Changed 13 years ago by
| Status: | new → confirmed |
|---|
Changed 13 years ago by
| Attachment: | 8812.patch added |
|---|
comment:2 Changed 13 years ago by
| Owner: | set to Frederico Caldeira Knabben |
|---|---|
| Status: | confirmed → review |
comment:3 Changed 13 years ago by
| Status: | review → review_failed |
|---|
Changed 13 years ago by
| Attachment: | 8812_2.patch added |
|---|
comment:4 Changed 13 years ago by
| Component: | General → Core : Selection |
|---|---|
| Status: | review_failed → review |
The previous patch was working on a sightly different tc than the provided one. Because of this I've updated the test, adding both tcs there.
The new patch fixes instead the root of the problem, which is related to the IE Range to CKEDITOR.dom.range transformation. This is a more global fix, which can help us avoiding unknown issues all around the code.
comment:6 Changed 13 years ago by
| Milestone: | → CKEditor 3.6.3 |
|---|
comment:7 Changed 13 years ago by
| Status: | review → review_failed |
|---|
Patch fails one tc that is added to the ticket test, pls check, basically the patch needs to change also the "else" block in the range mapping hunk.
Changed 13 years ago by
| Attachment: | 8812_3.patch added |
|---|
comment:8 Changed 13 years ago by
| Status: | review_failed → review |
|---|
comment:9 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:10 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [7415].
Note: See
TracTickets for help on using
tickets.
Patch fails the following tc:
http://ckeditor.t/tt/8812/1.html