Opened 6 years ago

Closed 6 years ago

#8874 closed Bug (fixed)

Shift+tab causes errors and incorrect caret and focus movements

Reported by: Piotrek Koszuliński Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.3
Component: General Version:
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

  1. Open replacebyclass.html sample
  2. Place cursor somewhere in the paragraph
  3. Press Shift+tab
  • On Chrome there's an error on console and caret moves to the beginning of the editable.
  • On Firefox there's an error and focus is lost.
  • Opera ignores shift and moves focus to submit button.
  • On IE8 editor loses focus.

Some of these incorrect behaviors (IE8 & Opera) are old, but error on Chrome&Fx is introduced by r7372, so it's a regression from 3.6.2.

Related issue: #8502

Attachments (2)

8874.patch (4.1 KB) - added by Garry Yao 6 years ago.
8874_2.patch (706 bytes) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:2 Changed 6 years ago by Jakub Ś

Status: newconfirmed

Confirmed for Chrome and Firefox.


As for IE8 and Opera IMO there is no error.
In Opera tab key goes only through editor instances and submit button and Shift+tab does the same the opposite way. Try with replacebycode sample.

In IE8 tab keys also go through browser's toolbar buttons so the focus is not lost it is moved back to those buttons.

Changed 6 years ago by Garry Yao

Attachment: 8874.patch added

comment:3 Changed 6 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

The patch eliminates the error while it doesn't bring any change to the focus manipulation as expected in #8502.

comment:4 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

Let's make the patch very small and simple, by simply adding that check inside getPrevious, without making other changes, not even adding a new dedicated constant.

Changed 6 years ago by Garry Yao

Attachment: 8874_2.patch added

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: review_failedreview_passed

comment:6 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7457].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy