Opened 12 years ago
Closed 10 years ago
#8899 closed Bug (fixed)
Links in the About dialog should open in a new window
| Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Jakub Ś |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.3.3 |
| Component: | UI : Dialogs | Version: | 3.0.1 |
| Keywords: | Cc: |
Description
Currently all the links in the "About" window are opened in the current window, causing loss of all the current data if the page hasn't implemented an onBeforeUnload handler.
If all the links are changed to launch in a new window such problem won't exist.
Change History (7)
comment:1 Changed 12 years ago by
| Status: | new → confirmed |
|---|---|
| Version: | → 3.0 |
comment:2 Changed 11 years ago by
| Version: | 3.0 → 3.0.1 |
|---|
comment:3 Changed 10 years ago by
| Owner: | set to Jakub Ś |
|---|---|
| Status: | confirmed → assigned |
comment:5 Changed 10 years ago by
| Status: | review → review_failed |
|---|
The patch may be good, but the t/8899 has been based on very old commit, instead of on latest master. Please rebase it or, what will be simpler, start it again after updating your master branch.
comment:6 Changed 10 years ago by
| Milestone: | → CKEditor 4.3.3 |
|---|---|
| Status: | review_failed → review_passed |
After the branch was fixed, R+.
comment:7 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on master with git:8fb204a on dev.
Note: See
TracTickets for help on using
tickets.
This is still an issue in latest CKEditor 4.x.