Opened 13 years ago
Closed 12 years ago
#8916 closed Bug (fixed)
Safari: Press delete button in an empty cell deleting empty Rows below current row
Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.0 |
Component: | Core : Keystrokes | Version: | |
Keywords: | IBM Webkit | Cc: | Damian, Teresa Monahan |
Description
To reproduce the defect:
- Open any CK Editor sample and insert a table with default values(3 Rows & 2 Columns).
- Don't enter any content in second or third rows.
- Enter the content in first cell in first row, leave second cell in first row empty.
- Keep cursor in the Second cell on first row & press Delete
Issue: Second row is deleted
- Press Delete again..
Issue: Next empty row gets deleted
Change History (9)
comment:1 Changed 13 years ago by
Keywords: | Webkit added |
---|---|
Status: | new → confirmed |
comment:3 Changed 13 years ago by
Just a guess but perhaps #8471 has the same cause for this behavior.
comment:4 Changed 13 years ago by
What is the plan to resolve this ticket?
As discussed with senior developers - This one will be aimed for v4 only, it's just complex for this release.
comment:5 Changed 12 years ago by
Component: | General → Core : Keystrokes |
---|---|
Milestone: | → CKEditor 4.0 |
Owner: | set to Garry Yao |
Status: | confirmed → assigned |
comment:6 Changed 12 years ago by
Status: | assigned → review |
---|
Opened t/8916: Backspace/Del keystrokes are now handled at the boundary of table cells, to move cursor.
comment:7 Changed 12 years ago by
I pushed rebased branch + small coding style fix.
Del/backspace behaviour is fixed on Webkits.
In the code I see that this fix is generic and I wonder if it shouldn't affect also IEs? I also think that this change may deserve a new TC.
comment:8 Changed 12 years ago by
Status: | review → review_passed |
---|
Making the change for all browsers makes sense, as it guarantees a unified behaviour among them, no matter their default behaviour. Considering that we're have that code for a single browser anyway, it is safe to just enlarge it to others.
I'm still not a big fan of making DEL a movement key. I prefer the IE behaviour for this TC, where nothing happens in this case.
Anyway, the proposed behaviour is "acceptable". Let's see if people will complain about it.
comment:9 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
There's a problem with having test coverage on keystroke handlers in v4, see #9300.
Reproducible in Webkit from CKEditor 3.0
Notes: