Opened 13 years ago
Closed 12 years ago
#8925 closed Bug (fixed)
FF: Window scrolls to top when closing the table properties dialog
Reported by: | Damian | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.4 |
Component: | General | Version: | 3.3 |
Keywords: | Firefox IBM | Cc: | Satya Minnekanti, Teresa Monahan |
Description
To reproduce:
- Create a table that is large enough to cause the editor scroll bar to appear.
- Edit the table by right-clicking inside the last row of the table
- Set the table alignment to left or right
- Click OK
Expected: Focus returns to the cell that was clicked into, the view remains in the same place on the document.
Actual: The cursor appears to remain in the cell, but the window scrolls to the top of the document.
The scrolling problem manifests itself whenever the dialog is discarded (either OK or Cancel button) and the alignment on the table is set to left or right.
Attachments (3)
Change History (13)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Keywords: | Firefox added |
---|---|
Status: | new → confirmed |
Version: | → 3.3 |
Clicking on already aligned table (it can't have focus) has caused editor to scroll up from CKEditor 3.3
Aligning table (from alignment set to none) like described in ticket has caused editor to scroll up from CKEditor 3.3.1
Reproducible only in Firefox.
Changed 12 years ago by
Attachment: | 8925.patch added |
---|
comment:3 Changed 12 years ago by
Milestone: | → CKEditor 3.6.4 |
---|---|
Owner: | set to Garry Yao |
Status: | confirmed → review |
comment:4 Changed 12 years ago by
Status: | review → assigned |
---|
Unfortunately that patch doesn't work once the element is modified, so it looks like it's an side effect brought by the focus call which cannot be worked around.
comment:6 Changed 12 years ago by
Status: | assigned → review |
---|
Propose to remove the "blink cursor" hack from #5622, which is outdated, is the root of this problem.
Changed 12 years ago by
Attachment: | 8925_2.patch added |
---|
comment:7 Changed 12 years ago by
Status: | review → review_failed |
---|
Well... that outdated hack is still valid for an outdated browser we still support: Firefox 3.6.
As we're dealing with something hard to fix and with browser bugs, we can at least reduce the incidence of this issue. So, instead of removing blinkCursor alltogether, what about enabling it just when CKEDITOR.env.version == 10902
?
Changed 12 years ago by
Attachment: | 8925_3.patch added |
---|
comment:9 Changed 12 years ago by
Status: | review → review_passed |
---|
comment:10 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7517].
This issue also occurs when the context menu is opened and closed on a table which has align set to left or right. The table must contain enough rows to make it larger than the editing viewpane.