Opened 5 years ago

Closed 4 years ago

#8940 closed Bug (duplicate)

filebrowser plugin breaks when the Array prototype is extended

Reported by: Pivotal Labs Owned by:
Priority: Normal Milestone:
Component: File Browser Version: 3.1.1
Keywords: HasPatch Cc:

Description

We are using CKEditor with Ember.js.

Ember.js extends the native javacript Array prototype to include some helpful properties and functions. This causes some usages of for(i in j) loops within the filebrowser plugin to break, as it is iterating over all the properties on Array (instead of the elements in the array).

The following patch works for us.

Attachments (1)

0001-ckeditor-working-with-patched-array-prototype.patch (1.2 KB) - added by Pivotal Labs 5 years ago.
patch to safely iterate over elements in Array

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by Pivotal Labs

patch to safely iterate over elements in Array

comment:1 Changed 5 years ago by Jakub Ś

Keywords: HasPatch added
Status: newconfirmed
Version: 3.6.33.1.1

Good finding @pivotal

Ticket reproducible form CKEditor 3.1.1

comment:2 Changed 4 years ago by Piotrek Koszuliński

Resolution: duplicate
Status: confirmedclosed

DUP of #10265.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy