Ticket #8940 (closed Bug: duplicate)

Opened 2 years ago

Last modified 12 months ago

filebrowser plugin breaks when the Array prototype is extended

Reported by: pivotal Owned by:
Priority: Normal Milestone:
Component: File Browser Version: 3.1.1
Keywords: HasPatch Cc:

Description

We are using CKEditor with Ember.js.

Ember.js extends the native javacript Array prototype to include some helpful properties and functions. This causes some usages of for(i in j) loops within the filebrowser plugin to break, as it is iterating over all the properties on Array (instead of the elements in the array).

The following patch works for us.

Attachments

0001-ckeditor-working-with-patched-array-prototype.patch (1.2 KB) - added by pivotal 2 years ago.
patch to safely iterate over elements in Array

Change History

Changed 2 years ago by pivotal

patch to safely iterate over elements in Array

comment:1 Changed 2 years ago by j.swiderski

  • Status changed from new to confirmed
  • Keywords HasPatch added
  • Version changed from 3.6.3 to 3.1.1

Good finding @pivotal

Ticket reproducible form CKEditor 3.1.1

comment:2 Changed 12 months ago by Reinmar

  • Status changed from confirmed to closed
  • Resolution set to duplicate

DUP of #10265.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy