Opened 7 years ago

Closed 7 years ago

#10265 closed Bug (fixed)

For...in loop over array in filebrowser plugin

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.1.1
Component: File Browser Version: 3.0
Keywords: Cc:

Description

Extracted from the pull request.

It feels like it was since filebrowser was created.

Change History (6)

comment:1 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newreview

Created branch t/10265 with the pull request + minor fixes.

comment:2 Changed 7 years ago by Wiktor Walc

Status: reviewreview_passed

The order in this particular loop does not matter, so the simplified for loop that loops over elements in reverse order is totally fine.

comment:3 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged into master git:8ad32febfbd90.

comment:4 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: closedreopened

comment:5 Changed 7 years ago by Piotrek Koszuliński

Closed #8940 as a DUP.

Last edited 7 years ago by Piotrek Koszuliński (previous) (diff)

comment:6 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reopenedclosed

Fixed directly on master with git:2be86aa.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy