Opened 10 years ago

Closed 9 years ago

#898 closed New Feature (fixed)

Add EditorAreaCSS to image preview

Reported by: redtopia@… Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6.1
Component: General Version:
Keywords: SF Review+ Cc:

Description

It would be a nice improvement for the image preview pane to view the image in the context of the current editor area CSS file. To do this, I've added this code to the <head> of the fck_image_preview.html file: (inside the exisiting <script>)

// Sets the editor area CSS
if (window.parent.FCKConfig.EditorAreaCSS.length > 0)
document.write( '<link href="' +
window.parent.FCKConfig.EditorAreaCSS + '"
type="text/css" rel="stylesheet">' ) ;

Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1496671&group_id=75348&atid=543656

Attachments (1)

898.patch (1.6 KB) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Proposed SVN patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Martin Kou

Reporter: changed from Martin Kou to redtopia@…

comment:2 Changed 9 years ago by Wojciech Olchawa

Keywords: HasPatch added

comment:3 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 898.patch added

Proposed SVN patch

comment:4 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added; HasPatch removed

This should be enough to be able to see the images with the classes applied to them.

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed
Milestone: FCKeditor 2.6.1

I don't want to Review- it just because of this, but please remove the indentation from lines 38 and 39 before committing.

comment:6 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [2023]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy