Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8997 closed Bug (fixed)

Styles are lost on sub-lists when converting from numbered list to bulleted list and vice versa

Reported by: Teresa Monahan Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.4
Component: Core : Lists Version: 3.3.2
Keywords: IBM Cc: Damian, Satya Minnekanti

Description

To Reproduce:

  • Copy the following content into the Source view of the editor. This is just a numbered list with 3 different levels. Each level has a font-size defined:
<ol style="font-size:20px;">
	<li>
		List 1</li>
	<li>
		List 1
		<ol style="font-size:16px;">
			<li>
				List 2</li>
			<li>
				List 2
				<ol style="font-size:12px;">
					<li>
						List3</li>
				</ol>
			</li>
		</ol>
	</li>
	<li>
		List 1</li>
</ol>

  • Return to wysiwyg mode and select the entire editor contents.
  • Click the Bulleted List icon in the toolbar to convert the list to a bulleted list.

Problem: The font styling for the sub-lists are lost. The font-size style for each sub-list is overwritten with the value from the top-level list:

<ul style="font-size: 20px;">
	<li>
		List 1</li>
	<li>
		List 1
		<ul style="font-size: 20px;">
			<li>
				List 2</li>
			<li>
				List 2
				<ul style="font-size: 20px;">
					<li>
						List3</li>
				</ul>
			</li>
		</ul>
	</li>
	<li>
		List 1</li>
</ul>

The styling for the sub-lists should be preserved. This also occurs when converting from bulleted lists to numbered lists.

Attachments (2)

8997.patch (1.4 KB) - added by Garry Yao 5 years ago.
8997_2.patch (1.6 KB) - added by Garry Yao 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by Jakub Ś

Component: GeneralCore : Lists
Status: newconfirmed
Version: 3.6.4 (SVN - trunk)3.3.2

This particular TC has been reproducible from CKEditor 3.3.2.

From CKE 3.0 till CKE 3.0.1 only style on top-level list was lost.

From CKE 3.0.2 till 3.3.1 all styles were lost.

comment:2 Changed 5 years ago by Garry Yao

Milestone: CKEditor 3.6.4
Owner: set to Garry Yao
Status: confirmedreview
Last edited 5 years ago by Frederico Caldeira Knabben (previous) (diff)

comment:3 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewassigned

Did you eventually forgot to attach the patch? :)

Last edited 5 years ago by Frederico Caldeira Knabben (previous) (diff)

Changed 5 years ago by Garry Yao

Attachment: 8997.patch added

comment:4 Changed 5 years ago by Garry Yao

Status: assignedreview

Oops, my fault.

comment:5 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

This test fails after patch:
http://ckeditor.t/tt/7290/1.html

Changed 5 years ago by Garry Yao

Attachment: 8997_2.patch added

comment:6 Changed 5 years ago by Garry Yao

Status: review_failedreview

comment:7 Changed 5 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:8 Changed 5 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

comment:9 Changed 5 years ago by Garry Yao

Fixed with [7508].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy