Opened 12 years ago
Closed 10 years ago
#9137 closed Bug (fixed)
base-tag is not outputeed when head-tag has an attribute
| Reported by: | fujikawa.naoki | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.5 |
| Component: | General | Version: | 3.1 |
| Keywords: | Cc: |
Description
/_source/plugins/wysiwygarea/plugin.js
L.991
baseTag && ( data = data.replace( /<head>/, '$&' + baseTag ) );
I think that it is not
/<head>/
but
/<head[^/>]*?>/
here.
Attachments (3)
Change History (13)
comment:1 Changed 12 years ago by
| Version: | → 3.6.4 (SVN - trunk) |
|---|
comment:2 Changed 12 years ago by
comment:3 Changed 12 years ago by
| Keywords: | base href removed |
|---|---|
| Version: | 3.6.4 (SVN - trunk) |
Please feel free to set the version number to the correct value when you confirm it.
comment:5 Changed 12 years ago by
| Status: | new → pending |
|---|
Hi,
Could you tell me how to reproduce this missing base tag in editor body? What is the scenario and does it happen in every browser?
I have tried pasting
<html> <head dir="ltr"> <title></title> <base href="http://localhost" target="_blank" /> </head> <body> <p> This is some <strong>sample text</strong>. You are using <a href="http://ckeditor.com/">CKEditor</a>.</p> </body> </html>
Switching to source and back but this works as expected.
comment:6 Changed 12 years ago by
Is that of WYSIWYG iframe source.
Editor1 the image is displayed when you open the html attachment, editor2 will not be displayed. Because, to editor2 is base tag has not been output to the iframe html source
There are differences in editor2 attribute to the head tag is not from the editor1.
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta content="text/html; charset=utf-8" http-equiv="content-type" />
<script type="text/javascript" src="http://ckeditor.com/apps/ckeditor/3.6.3/ckeditor.js"></script>
</head>
<body>
<label for="editor1">
<textarea cols="80" id="editor1" name="editor1" rows="10"><html>
<head>
<body><img src="screenshot.png"></body>
</head>
</html>
</textarea>
<label for="editor2">
<textarea cols="80" id="editor2" name="editor2" rows="10">
<html>
<head dir="ltr">
<body><img src="screenshot.png"></body>
</head>
</html>
</textarea>
<script type="text/javascript">
//<![CDATA[
CKEDITOR.replace( 'editor1',
{
fullPage : true,
baseHref : 'http://a.cksource.com/c/1/inc/img/'
});
CKEDITOR.replace( 'editor2',
{
fullPage : true,
baseHref : 'http://a.cksource.com/c/1/inc/img/'
});
//]]>
</script>
</body>
</html>
Could you confirm? Thank you.
Changed 12 years ago by
| Attachment: | 9137.patch added |
|---|
comment:7 Changed 12 years ago by
| Status: | pending → confirmed |
|---|---|
| Version: | 3.6.3 → 3.1 |
@fujikawa.naoki thank you for the file it shows the problem clearly. In editor two there is no image and source for second editor shows no base tag.
Issue has been reproducible from CKEditor 3.1 in all browsers.
comment:8 Changed 12 years ago by
Thank you for the confirmation. Does it solve for the next release?
comment:9 Changed 11 years ago by
I have just run into this same problem when editing a web page that contained the following as the head tag:
<head profile="http://gmpg.org/xfn/11">
The problem still persisted even after upgrading to version 4.0.1, so it apparently has not yet been fixed. Any ETA on a fix for this issue?
comment:10 Changed 10 years ago by
| Milestone: | → CKEditor 4.4.5 |
|---|---|
| Resolution: | → fixed |
| Status: | confirmed → closed |
Fixed on master with git:c9a0a2a thanks to https://github.com/ckeditor/ckeditor-dev/pull/121.
The version number is the lowest version of CKEditor, where the error can be reproduced. Are you sure that this error wasn't present in CKEditor 3.6.3, 3.6, 3.0 and so on?