Link Plugin and emailProtection='encode' problem

[Stan]

When I config CKEditor for emailProtection = 'encode' and try edit already encoded email address, Link Plugin Dialog parse email with postfix 'undefined' like this: test@…

[Jakub Ś]

and try edit already encoded email address

• I have set config.emailProtection = 'encode';
• Inserted email
• Edited it again and didn't have a problem.

Where exactly are you getting this issue - isn't this after you save your data into DB and then bring it up again? If that is the case then you should focus on encoding conflicts in your application, server, or DB.
Another thing might be for example double encoding or using wrong method to do that.

Is this the problem you are getting? Could you describe in more detail?

[Stan]

Its happen only if I no fill email description. When I fill description it is ok.

[Jakub Ś]

I assume that by description you mean Message Body. Is that correct?

With or without message Body I was not able to reproduce the problem.

Could you please provide step by step scenario explaining how to reproduce this problem?
If possible please provide screen cast (jing if good for these things).

[Stan]

Description means Message Title, but I tested no body content and it is same. And I found problem. Problem is Google Chrome, because in FF it is OK.

[Jakub Ś]

@standus thank you now it's clear.

To reproduce:

1. set config.emailProtection = 'encode';
2. Open editor sample
3. Open link dialog and chooe Email
4. Fill in only address files E.g. test@test.com
5. Click OK and then double-click on link to open dialog (or click and use toolbar button)

Result:
Address field will be test@test.comundefined

Problem has been reproducible from CKEditor 3.1 in Webkit, IE and Opera.
Firefox is the only browser that actually works with this TC.

[Jakub Ś]

#11919 was marked as duplicate.

[Stan]

What about this bug?

[Stan]

Not solved to last public version. Now 4.4.6! Ohhhh! Tested with Chrome 39.

[Jakub Ś]

#13022 was marked as duplicate.

[Gabriela]

I've corrected it in my version, which is CKEditor 3.6.6.

The bug is in file plugins/link/dialogs/link.js. This file is minified, so I took the unminified file from _source/plugins/link/dialogs/link.js.

In unminified file around line 112 there is a function which looks like that:

function ( match, protectedAddress, rest )
{
    if (typeof rest === 'undefined'){
        rest = '';
    }
    return 'mailto:' +
        String.fromCharCode.apply( String, protectedAddress.split( ',' ) ) + 
        ( rest && unescapeSingleQuote( rest ) );
});

and the usage of undefined rest variable causes the erroneous concatenated string. I've added line which checks out the state of the rest variable before return.

if (typeof rest === 'undefined'){
    rest = '';
}

[Tomasz Jakut]

Pushed fix with tests to ​branch:t/9192.

[Marek Lewandowski]

Great! Merged to master with ​git:cda09c7.