Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9221 closed Task (fixed)

Check the full page feature

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: General Version:
Keywords: Cc:

Description

We need to check full page mode work for themed and inlineui.

Change History (7)

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

comment:2 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_failed

Please rebase branch (and rename it from t/176 to t/9221) to the current master. There are conflicts.

comment:3 Changed 7 years ago by Garry Yao

Status: review_failedreview

comment:4 Changed 7 years ago by Piotrek Koszuliński

Could you describe what was fixed in this ticket? And what's the status of fullpage feature for inline editor?

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

As far as I understand, the full page thing was almost ready, with minor cleanup issues to be fixed, which have been fixed in the branch.

As for inline, it has nothing to do with full page. At least for now.

That's a good enough starting point. If anything can be refined, we can do that later.

comment:6 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

comment:7 Changed 7 years ago by Garry Yao

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy