#9221 closed Task (fixed)
Check the full page feature
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
We need to check full page mode work for themed and inlineui.
Change History (7)
comment:1 Changed 12 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → review |
comment:2 Changed 12 years ago by
| Status: | review → review_failed |
|---|
comment:3 Changed 12 years ago by
| Status: | review_failed → review |
|---|
comment:4 Changed 12 years ago by
Could you describe what was fixed in this ticket? And what's the status of fullpage feature for inline editor?
comment:5 Changed 12 years ago by
| Status: | review → review_passed |
|---|
As far as I understand, the full page thing was almost ready, with minor cleanup issues to be fixed, which have been fixed in the branch.
As for inline, it has nothing to do with full page. At least for now.
That's a good enough starting point. If anything can be refined, we can do that later.
comment:6 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
comment:7 Changed 12 years ago by
The review doesn't reveal a broken test, post-fixed with
https://github.com/ckeditor/ckeditor-dev/commit/df5d31adbb2da2780a670c088c2cd535ea567333
Note: See
TracTickets for help on using
tickets.
Please rebase branch (and rename it from t/176 to t/9221) to the current master. There are conflicts.