Opened 12 years ago

Closed 12 years ago

#9222 closed Bug (fixed)

[FF] Browser uses default cursor for inline editors

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

  1. Open http://ckeditor4.t/ckeditor/samples/inlineall.html
  2. Try editing any contenteditable.

There should be text cursor instead.

Change History (8)

comment:1 Changed 12 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newreview

Created branch t/9222.

I'm not sure why on FF default cursor is shown (because over simple content editable element it's correct 'text'), but this fix helps. It also fixes cursor for control elements like textarea and inputs on all other browsers (except IEs which by default render default cursor).

comment:2 Changed 12 years ago by Garry Yao

Status: reviewreview_failed

Let's have it fixed in editable.js instead, to avoid duplicating for each types of editable: _source/plugins/wysiwygarea/plugin.js#L1279

comment:3 Changed 12 years ago by Piotrek Koszuliński

But fixes for inline and framed editor are different. One for inline editor has to be prefixed with editor's class and added once per host page, when the one for framed editor has to be appended to the iframe's body and once per each editor. If we had more than 3 similar cases, then ok, but in this case we need two different solutions.

Last edited 12 years ago by Piotrek Koszuliński (previous) (diff)

comment:4 Changed 12 years ago by Piotrek Koszuliński

Status: review_failedreview

comment:5 Changed 12 years ago by Piotrek Koszuliński

Status: reviewreview_failed

Garry's right that these rules are specific for all editables, so it'd be better to keep them there.

comment:6 Changed 12 years ago by Piotrek Koszuliński

Status: review_failedreview

Currently only small improvement was possible - the cursor fix is done by editable.js. Better solution needs deep changes in adding CSS, so it would be possible to do this after editor creation.

comment:7 Changed 12 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:8 Changed 12 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on master. Before masterising I expanded this fix for divarea, which previously hasn't been included.

https://github.com/ckeditor/ckeditor-dev/commit/f532979

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy