Opened 7 years ago

Closed 7 years ago

#9253 closed Bug (fixed)

Resize feature should be disabled for maximized editor

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

How to reproduce:

I guess that either resize should be disabled in maximized mode or it should at least have no impact on the editor.

Change History (6)

comment:1 Changed 7 years ago by Olek Nowodziński

Status: newreview

Created dev branch. Ported v3 CSS solution.

Initially R+ by garry.yao.

comment:2 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Considering our skin files are published, let's just having the checked handled by the resize plugin instead, to reduce this extra effort on skin providers.

comment:3 Changed 7 years ago by Olek Nowodziński

Status: review_failedreview

Created branch t/9253b.

  • Added maximize event to the maximize plugin.
  • Now resize plugin observes the event and toggles the resizer according to the state.

comment:4 Changed 7 years ago by Piotrek Koszuliński

Reviewing...

comment:5 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:6 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Fixed with b852334. Masterized.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy