Opened 12 years ago
Closed 12 years ago
#9256 closed Bug (fixed)
Paragraph added before <hr>
| Reported by: | Frederico Caldeira Knabben | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | General | Version: | 4.0 |
| Keywords: | Cc: |
Description
With FF at least:
- Paste the following into source view:
<hr /> <p>Text</p>
- Switch to wysiwyg.
An empty paragraph will be added at the top of the contents.
Change History (10)
comment:1 Changed 12 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → review |
comment:2 Changed 12 years ago by
| Status: | review → review_failed |
|---|
Change is good, but tests have to be aligned to it.
Failing:
comment:3 Changed 12 years ago by
| Status: | review_failed → review |
|---|
The above failures, are instead a regression of the previous patch - as an exception, auto paragraphing should still work when inside of empty editable.
comment:5 Changed 12 years ago by
| Status: | review → review_failed |
|---|
comment:6 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Pushed commit 74ace199be (Corrected range after empty block removal.) on review branch.
comment:7 Changed 12 years ago by
| Status: | review → review_failed |
|---|
After f28b03355acc300c3a97ce97ea82743fd89cc45f original TC is failing.
comment:8 Changed 12 years ago by
| Status: | review_failed → review |
|---|
I've reworked a bit more of code, to do pre-checking instead, the branch is rewritten.
comment:10 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Note: See
TracTickets for help on using
tickets.
We're now able to remove our last legacy code that introduces automatic blocking, after two years, thanks to the magicline feature.