Opened 7 years ago

Closed 7 years ago

#9256 closed Bug (fixed)

Paragraph added before <hr>

Reported by: Frederico Caldeira Knabben Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

With FF at least:

  1. Paste the following into source view:
<hr />
<p>Text</p>
  1. Switch to wysiwyg.

An empty paragraph will be added at the top of the contents.

Change History (10)

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

We're now able to remove our last legacy code that introduces automatic blocking, after two years, thanks to the magicline feature.

comment:3 Changed 7 years ago by Garry Yao

Status: review_failedreview

The above failures, are instead a regression of the previous patch - as an exception, auto paragraphing should still work when inside of empty editable.

comment:4 Changed 7 years ago by Piotrek Koszuliński

Closer :) Only one TC failing on IE8 :). On Chrome 100% green.

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

comment:6 Changed 7 years ago by Garry Yao

Status: review_failedreview

Pushed commit 74ace199be (Corrected range after empty block removal.) on review branch.

comment:7 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_failed

After f28b03355acc300c3a97ce97ea82743fd89cc45f original TC is failing.

comment:8 Changed 7 years ago by Garry Yao

Status: review_failedreview

I've reworked a bit more of code, to do pre-checking instead, the branch is rewritten.

comment:9 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_passed

100% green.

comment:10 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy