Opened 12 years ago
Closed 12 years ago
#9281 closed Bug (fixed)
Safari: Error on table dialog when border:none is added to the styles field
Reported by: | Teresa Monahan | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.5 |
Component: | General | Version: | 3.0 |
Keywords: | IBM | Cc: | Damian, Satya Minnekanti |
Description
To Reproduce:
- Open any sample in Safari and insert a table.
- Open the Advanced tab on the table dialog, specify the following in the styles field and click OK:
width: 500px; border:none;
- Open the Table Properties dialog again and click Ok.
Problem: The error dialog displays saying that the syntax of the styles field is incorrect.
If you look at the value of the styles field it now has the following value:
border-top-style: none; border-right-style: none; border-bottom-style: none; border-left-style: none; border- border-color: initial; width: 500px;width: initial
The border- before border-color: initial; causes the error to appear.
This error only occurs if the width styling is also applied.
This can also be reproduced easily when pasting a standard table from Word that has a width set with the following configuration options:
config.pasteFromWordRemoveFontStyles = false; config.pasteFromWordRemoveStyles = false;
Attachments (1)
Change History (5)
Changed 12 years ago by
Attachment: | 9281.patch added |
---|
comment:1 Changed 12 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → review |
comment:2 Changed 12 years ago by
Milestone: | → CKEditor 3.6.5 |
---|---|
Version: | 3.6.5 (SVN - trunk) → 3.0 |
comment:3 Changed 12 years ago by
Status: | review → review_passed |
---|
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7622].
It's caused by an incomplete impl of the dialogadvtab plugin's updateStyle function, which incorrectly removed 'border-width' when removing the style "width", propose to switch to DOM-based computation, to properly handle complex case, e.g. CSS property components.
Opened ticket test: http://ckeditor.t/dt/plugins/dialogadvtab/1.html