Opened 13 years ago
Closed 13 years ago
#9286 closed Bug (fixed)
CKEDITOR.config#keystrokes - update docs
| Reported by: | Piotrek Koszuliński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | General | Version: | 4.0 |
| Keywords: | Cc: |
Description
Pretty important change has been made in v4. See: http://cksource.com/forums/viewtopic.php?f=6&t=26990
Change History (11)
comment:1 Changed 13 years ago by
| Summary: | CKEDITOR.config.keystrokes - update docs → CKEDITOR.config#keystrokes - update docs |
|---|
comment:2 Changed 13 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | new → assigned |
comment:3 Changed 13 years ago by
| Status: | assigned → review |
|---|
comment:4 follow-up: 5 Changed 13 years ago by
| Status: | review → review_failed |
|---|
I've not able to find t/9286@cksource... are you sure you pushed it?
comment:5 Changed 13 years ago by
| Status: | review_failed → review |
|---|
Replying to fredck:
I've not able to find t/9286@cksource... are you sure you pushed it?
Yeah, I forgot to push. Now it's fine, I guess. Sorry for that.
comment:6 Changed 13 years ago by
| Status: | review → review_failed |
|---|
We should not recommend user the usage of hacking keystrokes on "instanceReady", it's enough to leave there the documentation for how to block a keystroke.
Resetting all keystrokes is considered harmful to the editor, instead user need to override each of them, or block it, under the acknowledgement of each keystroke's function.
comment:7 Changed 13 years ago by
| Status: | review_failed → review |
|---|
Yes, resetting all keystrokes is harmful. People ask for this though. This is why I think we should keep this information with an appropriate notice (warning).
Updated t/9286 branch.
comment:8 follow-up: 9 Changed 13 years ago by
| Status: | review → review_failed |
|---|
Can we instead recommend the following for blocked keystroke, as the current one is pretty counter-intuitive.
// Blocked CTRL + L config.keystrokes = [[ CKEDITOR.CTRL + 76, null ]]
V.S.
// Blocked CTRL + L ? config.keystrokes = [[ CKEDITOR.CTRL + 76 ]]
comment:9 Changed 13 years ago by
| Status: | review_failed → review |
|---|
Replying to garry.yao:
// Blocked CTRL + L config.keystrokes = [[ CKEDITOR.CTRL + 76, null ]]
This one looks fine. I've just updated the t/9286.
comment:10 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:11 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Created dev branch t/9286 with updated docs.