Opened 7 years ago

Closed 7 years ago

#9286 closed Bug (fixed)

CKEDITOR.config#keystrokes - update docs

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

Pretty important change has been made in v4. See: http://cksource.com/forums/viewtopic.php?f=6&t=26990

Change History (11)

comment:1 Changed 7 years ago by Piotrek Koszuliński

Summary: CKEDITOR.config.keystrokes - update docsCKEDITOR.config#keystrokes - update docs

comment:2 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:3 Changed 7 years ago by Olek Nowodziński

Status: assignedreview

Created dev branch t/9286 with updated docs.

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

I've not able to find t/9286@cksource... are you sure you pushed it?

comment:5 in reply to:  4 Changed 7 years ago by Olek Nowodziński

Status: review_failedreview

Replying to fredck:

I've not able to find t/9286@cksource... are you sure you pushed it?

Yeah, I forgot to push. Now it's fine, I guess. Sorry for that.

comment:6 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

We should not recommend user the usage of hacking keystrokes on "instanceReady", it's enough to leave there the documentation for how to block a keystroke.

Resetting all keystrokes is considered harmful to the editor, instead user need to override each of them, or block it, under the acknowledgement of each keystroke's function.

comment:7 Changed 7 years ago by Olek Nowodziński

Status: review_failedreview

Yes, resetting all keystrokes is harmful. People ask for this though. This is why I think we should keep this information with an appropriate notice (warning).

Updated t/9286 branch.

comment:8 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Can we instead recommend the following for blocked keystroke, as the current one is pretty counter-intuitive.

// Blocked CTRL + L
config.keystrokes = [[ CKEDITOR.CTRL + 76, null ]]

V.S.

// Blocked CTRL + L ?
config.keystrokes = [[ CKEDITOR.CTRL + 76 ]]

comment:9 in reply to:  8 Changed 7 years ago by Olek Nowodziński

Status: review_failedreview

Replying to garry.yao:

// Blocked CTRL + L
config.keystrokes = [[ CKEDITOR.CTRL + 76, null ]]

This one looks fine. I've just updated the t/9286.

comment:10 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:11 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy