Opened 7 years ago

Closed 7 years ago

#9355 closed Bug (fixed)

Menu panel never shrinks

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Floating Panel Version: 4.0
Keywords: Cc:

Description

Use the following HTML:

<textarea cols="80" id="editor1" name="editor1" rows="10">			
	&lt;table&gt;
		&lt;tr&gt;
			&lt;td&gt;cell&lt;/td&gt;
		&lt;/tr&gt;
	&lt;/table&gt;
	This is some text.
</textarea>

To create an editor with extended context menu label:

CKEDITOR.replace( 'editor1' );

CKEDITOR.on( 'instanceLoaded', function( evt ) {
	evt.editor._.menuItems.tablecell.label = CKEDITOR.tools.repeat( evt.editor.lang.table.cell.menu, 10 );
});
  1. Right-click on the text. A narrow context menu is shown.
  2. Right-click the table. A very wide context menu is shown.
  3. Again, right-click on the text. The menu is still wide. It's nothing like this from 1.

Attachments (1)

contextMenuNoShrink.png (10.3 KB) - added by Olek Nowodziński 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Olek Nowodziński

Attachment: contextMenuNoShrink.png added

comment:1 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newreview

Created branch t/9355 with a solution.

comment:2 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

Nice catch, it even not a v3 regression.

comment:3 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Small glitches:

target.setStyle( 'width', null ) -> target.removeStyle( 'width' )

Besides ticket number should present in comment line.

Fixed on master with:

https://github.com/ckeditor/ckeditor-dev/commit/4e28f675834a3da148fa7d47cc166e33578a5cc0

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy