Opened 12 years ago
Closed 12 years ago
#9359 closed Bug (fixed)
[IE, RTL] Dialog layout is broken under IE
| Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | UI : Dialogs | Version: | 4.0 |
| Keywords: | IE | Cc: |
Description
Tested in IE9.
Attachments (7)
Change History (16)
Changed 12 years ago by
| Attachment: | dialogBrokenIeRtl.png added |
|---|
comment:1 Changed 12 years ago by
| Keywords: | IE added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
comment:2 Changed 12 years ago by
| Status: | assigned → review |
|---|
Changed 12 years ago by
| Attachment: | IE7dialogRTLvsLTR.png added |
|---|
Changed 12 years ago by
| Attachment: | IE8dialogRTLvsLTR.png added |
|---|
Changed 12 years ago by
| Attachment: | IE9dialogRTLvsLTR.png added |
|---|
Changed 12 years ago by
| Attachment: | bouncingButtonHover.gif added |
|---|
comment:3 Changed 12 years ago by
| Status: | review → review_failed |
|---|
I reviewed your changes. It's much better but unfortunately there's still a lot of work to do.
There's a number of things which are inconsistent in IE7+:
A cross-browser 1px issue on hover:
comment:4 Changed 12 years ago by
| Owner: | changed from Garry Yao to Olek Nowodziński |
|---|---|
| Status: | review_failed → assigned |
comment:5 Changed 12 years ago by
| Status: | assigned → review |
|---|
Updated t/9359 branch and rebased on the latest master.
From now on, dialog buttons (footer) should be consistent throughout supported browsers.
Changed 12 years ago by
| Attachment: | 9359_rtl_border-radius.png added |
|---|
comment:6 Changed 12 years ago by
| Status: | review → review_failed |
|---|
IE9 on RTL loose border-radius on button right side:
Changed 12 years ago by
| Attachment: | IE9buttonCut.png added |
|---|
comment:8 Changed 12 years ago by
| Status: | review → review_passed |
|---|
Sorry it may be caused by cache, WFM now.
comment:9 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed and masterized.
Note: See
TracTickets for help on using
tickets.
Opened t/9359 on dev for review, composed of two commits: