Opened 7 years ago

Closed 7 years ago

#9446 closed Bug (fixed)

[FF] instanceReady isn't fired when initializing editor inside invisible element

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

  1. Save attached sample into the sample/ directory and open it.
  2. Check console.
  • Expected: "ready to go!" reported.
  • Actual: error reported (see #8578).

Attachments (2)

displaynone.html (404 bytes) - added by Piotrek Koszuliński 7 years ago.
displaynone.2.html (514 bytes) - added by Piotrek Koszuliński 7 years ago.
Improved sample - it's possible to show hidden editor.

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by Piotrek Koszuliński

Attachment: displaynone.html added

comment:1 Changed 7 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:2 Changed 7 years ago by Jakub Ś

Status: newconfirmed

I have checked this in FF16. There was an infinite loop error and it was actually no way exit page as error was popping out all the time. I had to kill the browser.

Firefox 3.6 showed this error:
Message: too much recursion
Code:return new CKEDITOR.dom.document( th...| this.$.parentNode.ownerDocument );
URI: /ckeditor4/core/dom/node.js

comment:3 Changed 7 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:4 Changed 7 years ago by Piotrek Koszuliński

Status: assignedreview

I pushed branches t/9446.

Changed 7 years ago by Piotrek Koszuliński

Attachment: displaynone.2.html added

Improved sample - it's possible to show hidden editor.

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

I pushed a simplified element#getDirection impl, it works for the tc, but we'll need tests for this ticket.

comment:6 Changed 7 years ago by Garry Yao

Besides, if the ticket scope has expanded to make editor creation feasible inside of hidden element, note that in Webkit editor will be missing the wysiwyg area after shown.

comment:7 Changed 7 years ago by Piotrek Koszuliński

Status: review_failedreview

I pushed rebased branches.

  1. I checked Webkit and everything seem to be fine with wysiwyg area after shown. Isn't it?
  2. I created tests for this ticket. Aren't they enough?

comment:8 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

Ok for now, tks, pls squash the commits on masterisation.

comment:9 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy