Opened 6 years ago
Closed 6 years ago
#9446 closed Bug (fixed)
[FF] instanceReady isn't fired when initializing editor inside invisible element
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | General | Version: | 4.0 |
| Keywords: | Cc: |
Description (last modified by )
- Save attached sample into the sample/ directory and open it.
- Check console.
- Expected: "ready to go!" reported.
- Actual: error reported (see #8578).
Attachments (2)
Change History (11)
Changed 6 years ago by
| Attachment: | displaynone.html added |
|---|
comment:1 Changed 6 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 6 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 6 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
Changed 6 years ago by
| Attachment: | displaynone.2.html added |
|---|
Improved sample - it's possible to show hidden editor.
comment:5 Changed 6 years ago by
| Status: | review → review_failed |
|---|
I pushed a simplified element#getDirection impl, it works for the tc, but we'll need tests for this ticket.
comment:6 Changed 6 years ago by
Besides, if the ticket scope has expanded to make editor creation feasible inside of hidden element, note that in Webkit editor will be missing the wysiwyg area after shown.
comment:7 Changed 6 years ago by
| Status: | review_failed → review |
|---|
I pushed rebased branches.
- I checked Webkit and everything seem to be fine with wysiwyg area after shown. Isn't it?
- I created tests for this ticket. Aren't they enough?
comment:8 Changed 6 years ago by
| Status: | review → review_passed |
|---|
Ok for now, tks, pls squash the commits on masterisation.
comment:9 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Squashed & masterised https://github.com/ckeditor/ckeditor-dev/commit/067a18d
Note: See
TracTickets for help on using
tickets.
I have checked this in FF16. There was an infinite loop error and it was actually no way exit page as error was popping out all the time. I had to kill the browser.
Firefox 3.6 showed this error:
Message: too much recursion
Code:
return new CKEDITOR.dom.document( th...| this.$.parentNode.ownerDocument );URI: /ckeditor4/core/dom/node.js