Opened 7 years ago

Last modified 7 years ago

#9458 confirmed New Feature

Inline editing does not render iframes

Reported by: Aldo Sarmiento Owned by:
Priority: Normal Milestone:
Component: General Version: 4.0
Keywords: Cc:

Description

Prerequisites:

  1. Must have Iframe button enabled
  2. Must be using inline editing feature

Steps to reproduce:

  1. Click on Iframe button and add an iframe

Result: You will see a placeholder image representing the area the Iframe will be occupying Expected result: You should see the actual iframe being rendered inline.

I understand that for non-inline editing this functionality could make sense. However, with inline editing a user will never be able to see what the finished content will actually look like unless all editors are removed from the page.

Example:

http://i.imgur.com/ZYF6u.png

In the case above, the user would never be able to see his embedded video unless he logs out and inline editors are not present.

Change History (3)

comment:1 Changed 7 years ago by Wiktor Walc

Things to investigate:

  • proper selection of such elements
  • proper handling in plugins like find/replace
  • possible issues with sites included in an iframe that e.g. have JS errors, same with flash content that can also execute JS
  • using context menu on such elements

comment:2 Changed 7 years ago by Jakub Ś

Status: newconfirmed
Type: BugNew Feature

This is more feature request than a bug thus I'm changing the type.

Few more things to investigate:

  • some protection against invalid URL for iframe may be needed (404 placeholder maybe)
  • some protection against some malicious iframe (iframe with some malicious JS) may also be needed (encoding JS maybe)

comment:3 Changed 7 years ago by Jakub Ś

Note: this is only v4 issue (inline editing is available in V4 only).

Last edited 7 years ago by Jakub Ś (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy