[Opera&Framed] Focus is lost after clicking in linki inside a combo or editor

[Piotrek Koszuliński]

Test case 1

1. Open attached sample and open console (ctrl+shift+i on Opera).
2. Select text in editor.
3. Open font-size combo and click some value.

• Expected: no blur logged on console.
• Actual: focus, selectionChange, selectionChange, blur.

It's also possible to verify that something's wrong by selecting different parts of text in editor. Toolbar buttons like bold should react, but because selectionChange isn't fired that's not happening.

After investigation we're pretty sure that this is caused by async focus fired on link inside combo. Click on this link causes correct panel.close() && editor.focus(), but then deferred focus happens and moves focus back to panel.

Test case 2

1. Open attached sample and open console (ctrl+shift+i on Opera).
2. Focus editor.
3. Click link inside editor.

• Expected: no blur logged on console
• Actual: focus, selectionChange, selectionChange, blur.

[Piotrek Koszuliński]

Another place where click causes blur is space under content.

[Piotrek Koszuliński]

I've tested some ways to block focus event on elements outside editable. E.g.:

1. Forcing editor.focus() inside focus listener helped, but this solution is hacky and inconvenient - such listener would have to be added to all links - so inside combos, color palettes, etc.
2. Locking focusManager for few ms in click listener. That helped and looks promising.

Unfortunately it turned out that selectionChange haven't been fired after performing TCs mentioned in this ticket not because of focus lost, but editor returning all the time the same selection. This broken state resets after next correct blur/focus. I'll report new issue for that after I gather more information (update: #9464).

[Piotrek Koszuliński]

Pushed t/9459 with Garry's fix.

[Piotrek Koszuliński]

R+, because this is the cleanest solution of all.

[Piotrek Koszuliński]

Masterised: ​https://github.com/ckeditor/ckeditor-dev/commit/2d37350