Magicline: no accessibility support

[Frederico Caldeira Knabben]

There must be an accessibility solution to make magicline usable through the keyboard only.

[Frederico Caldeira Knabben]

There is a proposal for this.

To define a keyboard shortcut. When this is invoked, use the current selection to determine whether the magicline feature should be available directly above the current block or not. If it should be available, then execute it. If the magicline UI should not be available, nothing should happen.

This sounds like the bet solution for this right now.

[Piotrek Koszuliński]

Some details can be found in DUP of this tickets: #9695.

[Olek Nowodziński]

Created branches:

• t/9481@cksource
• t/9481@ckeditor-tests-v4

Added accessibility support by assigning CTRL+< and CTRL+> keystrokes to accessSpaceBefore|After commands. Keystrokes are temporary; they'll most likely be changed to something else after the review.

Best testing goes on ​http://ckeditor4.t/ckeditor/plugins/magicline/samples/magicline.html

[Piotrek Koszuliński]

Everything looks good except documentation and comments.

1. There are outdated and incorrect doc strs for magicline_keystrokeBefore and magicline_keystrokeAfter - note that two of them concerns one setting.
2. Comments for default keystrokes indicate CTRL+< and CTRL+> keystrokes when CTRL+, and CTRL+. are default ones.

BTW. CTRL+[ and CTRL+] may be better keystrokes, because they don't need SHIFT.

[Olek Nowodziński]

• Changed keystrokes to CTRL+[, CTRL+]
• Enabled and fixed docs.
• Renamed commands to avoid ambiguities.
• Aligned dts to renamed commands.

[Olek Nowodziński]

• Updated magicline keystroke access to ignore accessible (like DIV, TABLE, etc.) elements when looking for sibling triggers to insert paragraph before/after them. For inaccessible elements (e.g. HRs), the feature works as before.
• Updated tests to match current plugin implementation.

[Frederico Caldeira Knabben]

Let's have CTRL+ALT+[ and CTRL+ALT+] as keystrokes, because the proposed ones conflict with browsers keystrokes on mac to navigate back and forth in the history.

[Olek Nowodziński]

Pushed ​git:5c101ed, which updates default keystrokes and binds them to the plugin (forgot to do this before).

[Piotrek Koszuliński]

Force pushed rebased branches.

[Piotrek Koszuliński]

R+, but fix coding style issues in lines: 711, 821, 820 (var\t).

[Olek Nowodziński]

• Closed dev with ​git:a77c85fee5 on master.
• Closed tests with e2293b3.

[Satya Minnekanti]

It's not possible to insert a new paragraph before the table with key board shortcut if first table cell has numbered/bulleted list as it's content. Same issue happens with inserting a paragraph after the table if last table cell has numbered/bulleted list as it's content.Can you please re-open this ticket and fix the issue

[Satya Minnekanti]

The keyboard shortcuts for magicline feature CTRL+ALT+[ and CTRL+ALT+] needs to be added to Accessibility Instructions dialog & it should clearly explain when to use CTRL+ALT+[ & when to use CTRL+ALT+]

[Satya Minnekanti]

It's not possible to insert a new paragraph before the table with key board shortcut if first table cell has div as it's first element. Same issue happens with inserting a paragraph after the table if last table cell has div as it's last element.

[Olek Nowodziński]

Replying to satya:

It's not possible to insert a new paragraph before the table with key board shortcut if first table cell has numbered/bulleted list as it's content. Same issue happens with inserting a paragraph after the table if last table cell has numbered/bulleted list as it's content.Can you please re-open this ticket and fix the issue

It's not possible to insert a new paragraph before the table with key board shortcut if first table cell has div as it's first element. Same issue happens with inserting a paragraph after the table if last table cell has div as it's last element.

The origin of this issue is known - there are also other similar cases that we must deal with (like definition list). It's also related to #9833.

Thanks for feedback!

[Olek Nowodziński]

Pushed t/9481b branches to ​dev and tests, including:

• Improved keystroke access so successive execution removes unchanged focus spaces. This change comes with rich undo/redo support and solves comment:16.
• Smarter focus space search that solves related #9833.
• Various tests for enhanced command/keystroke access.
• Accessibility dialog docs for magicline keystroke access (comment:18).

[Piotrek Koszuliński]

Ok. There's an issue regarding last commit in that branch. Updating translations hasn't gone very well, because langtools got lost in that items array. I discussed that with Wiktor and I need to update them manually.

[Piotrek Koszuliński]

Pushed t/9481c with fixed translations.

[Piotrek Koszuliński]

<div>div1</div>

<div>
  <p>p1</p>
  <ul><li>li1^</li></ul>
</div>

Accessing previous focus space doesn't work in this case. It works after switching "li1" into paragraph and from p1 paragraph.

Except this (if this is really an issue) commands seem to work perfectly.

PS. For one of us which will be closing this issue - there are tests on t/9481b.

[Piotrek Koszuliński]

I extracted above issue to #9860. In fact it's a little bit different issue.

Fixed this issue with ​git:a6aa231.