Opened 7 years ago

Closed 7 years ago

#9491 closed Bug (fixed)

Moono wall of shame

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Skins Version: 4.0
Keywords: Cc:

Description (last modified by Olek Nowodziński)

Since Moono is our default skin in master branch, we should make it even better. This is the place for collecting Moono issues that must be fixed before the release.

Screenshots are welcome.


Buglist ported from #9423

  • No document properties icon
  • No vertical space between selected color and its hex representation in color picker (scr1).
  • Text in native select is too low (scr3).
  • Blue links in about dialog don't look good.
  • IE9: No horizontal separation of dialog footer and body screen
  • IE7 crops the bottom pixels of footer buttons
  • Bad UI Color support for dialog tab hover. screen
  • FF36: Dialog tabs and resizer float outside of the dialog.
  • IE7: Broken dialog layout introduced by box-sizing and field paddings. screen
  • (scr4) On Firefox box-shadow: inset is much stronger than on Chrome. I like the Chrome's version more, because it's cleaner. What's more - this shadow is rendered only... sometimes (scr7). It's definitely FF's bug but maybe we can bypass it.
  • (scr5) Again on FF box shadow is too strong - much stronger than on Chrome.
  • Narrow inputs in UI Color dialog

Attachments (3)

9491-6.png (7.7 KB) - added by Garry Yao 7 years ago.
9491-7.png (2.8 KB) - added by Garry Yao 7 years ago.
9491-8.png (40.9 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 7 years ago by Garry Yao

Listed here some other issues I found:

  • Dialog tab misses hover style
  • Dialog button misses active style
  • Dotted focus outline for select field (not consistent with text input) (sc)
  • [IE<9] Dialog overflows (sc)
  • [IE Quirks] Layout is messed up (sc)
Last edited 7 years ago by Olek Nowodziński (previous) (diff)

Changed 7 years ago by Garry Yao

Attachment: 9491-6.png added

Changed 7 years ago by Garry Yao

Attachment: 9491-7.png added

comment:2 Changed 7 years ago by Olek Nowodziński

Masterized t/9491_16px with 16px iconset.

Changed 7 years ago by Garry Yao

Attachment: 9491-8.png added

comment:3 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

Created t/9491@cksource for bug fixing and development.

comment:4 Changed 7 years ago by Olek Nowodziński

Description: modified (diff)

comment:5 Changed 7 years ago by Olek Nowodziński

Description: modified (diff)

comment:6 Changed 7 years ago by Olek Nowodziński

Description: modified (diff)

comment:7 Changed 7 years ago by Olek Nowodziński

Description: modified (diff)

comment:8 Changed 7 years ago by Olek Nowodziński

Description: modified (diff)

comment:9 Changed 7 years ago by Olek Nowodziński

Description: modified (diff)

comment:10 Changed 7 years ago by Olek Nowodziński

Description: modified (diff)

comment:11 Changed 7 years ago by Olek Nowodziński

Status: assignedreview

I'm putting t/9491@cksource for review, which seems to fix all considerable issues (mostly dialogs and IEs). Other bugs will be split into separate tickets and fixed later.

comment:12 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

Wonderful results, really. A good step forward.

There may be things still missing, but let's move on masterising this one and closing this tickets.

Please open individual tickets for the remaining known issues.

comment:13 Changed 7 years ago by Olek Nowodziński

Masterized t/9491@cksource. Remaining #9491 issues will be split into separate tickets.

Masterized t/9491_iconfix@cksource.

Please, don't close this ticket yet as some branches are associated with it (like t/9491_iconfix@cksource).

Last edited 7 years ago by Olek Nowodziński (previous) (diff)

comment:14 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy