Opened 7 years ago

Closed 7 years ago

#9639 closed Bug (fixed)

sourcearea plugin availablity

Reported by: Garry Yao Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 4.0
Component: Documentation & Samples Version: 4.0
Keywords: Cc:

Description

With preset-basic build profile, the editor is built without the sourcearea plugin, this causes a trouble on some samples that it fails to demonstrate the subject, e.g. fullpage and various output samples.

Change History (14)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

With now, presenting a message like this is more than enough:
"To fully experience this demo, the x, y and z plugins are required. These plugins are not available on your editor installation.". And that's it, nothing else.

We don't need over-complications because of this at this stage.

comment:2 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

Opened dev branch t/9639b for review, it added the compliance check for sample pages, prompt with a warning if necessary.

Based on the branch proposal, a meta is required to indicate a sample that requires source view capacity:

<meta name="ckeditor-sample-tags" content="output">

The tags can be extended later when needed.

comment:3 Changed 7 years ago by Garry Yao

Component: GeneralDocumentation & Samples

comment:4 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:5 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

comment:6 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: closedreopened

We've done two mistakes:

  1. samples.js should be included only in samples that need it.
  2. Simplified meta name (and logic) should've been proposed "ckeditor-sample-required-plugins"

comment:7 Changed 7 years ago by Garry Yao

Status: reopenedreview

Reopened t/9639 for review.

comment:8 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_passed

R+, but please fix coding style on commit.

comment:9 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

comment:10 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: closedreopened

The fix doesn't do its job, other than still being over-complicated. Just replace sourcearea with abc on the new meta and no warning is shown.

I'm taking this over.

comment:11 Changed 7 years ago by Frederico Caldeira Knabben

Status: reopenedconfirmed

comment:12 Changed 7 years ago by Frederico Caldeira Knabben

Owner: changed from Garry Yao to Frederico Caldeira Knabben
Status: confirmedassigned

comment:13 Changed 7 years ago by Frederico Caldeira Knabben

Status: assignedreview

Pushed t/9639.

comment:14 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: reviewclosed

Fixed with [70db2b1].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy