Opened 12 years ago
Closed 12 years ago
#9639 closed Bug (fixed)
sourcearea plugin availablity
Reported by: | Garry Yao | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.0 |
Component: | Documentation & Samples | Version: | 4.0 |
Keywords: | Cc: |
Description
With preset-basic build profile, the editor is built without the sourcearea plugin, this causes a trouble on some samples that it fails to demonstrate the subject, e.g. fullpage and various output samples.
Change History (14)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → review |
Opened dev branch t/9639b for review, it added the compliance check for sample pages, prompt with a warning if necessary.
Based on the branch proposal, a meta is required to indicate a sample that requires source view capacity:
<meta name="ckeditor-sample-tags" content="output">
The tags can be extended later when needed.
comment:3 Changed 12 years ago by
Component: | General → Documentation & Samples |
---|
comment:4 Changed 12 years ago by
Status: | review → review_passed |
---|
comment:5 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed on master with:
https://github.com/ckeditor/ckeditor-dev/commit/3f21dcc878026f849784f7d568d35e1ab872b2cc
Opened #9644 in seeking for a solution.
comment:6 Changed 12 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
We've done two mistakes:
- samples.js should be included only in samples that need it.
- Simplified meta name (and logic) should've been proposed
"ckeditor-sample-required-plugins"
comment:8 Changed 12 years ago by
Status: | review → review_passed |
---|
R+, but please fix coding style on commit.
comment:9 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Re-fixed on master with:
https://github.com/ckeditor/ckeditor-dev/commit/a16ec5b6bc0a51a83ad7f88be3af903749b84493
comment:10 Changed 12 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
The fix doesn't do its job, other than still being over-complicated. Just replace sourcearea with abc on the new meta and no warning is shown.
I'm taking this over.
comment:11 Changed 12 years ago by
Status: | reopened → confirmed |
---|
comment:12 Changed 12 years ago by
Owner: | changed from Garry Yao to Frederico Caldeira Knabben |
---|---|
Status: | confirmed → assigned |
comment:14 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Fixed with [70db2b1].
With now, presenting a message like this is more than enough:
"To fully experience this demo, the x, y and z plugins are required. These plugins are not available on your editor installation.". And that's it, nothing else.
We don't need over-complications because of this at this stage.